fix: Fix download blobxfer when BLOBXFER_REMOTE_PATH has folders#474
Open
eoehen wants to merge 1 commit into
Open
fix: Fix download blobxfer when BLOBXFER_REMOTE_PATH has folders#474eoehen wants to merge 1 commit into
eoehen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Blobxfer was configured with a nested remote path (for example /test/weekly/), each backup cycle could reintroduce the same path segment and produce recursive nesting over time (for example /test/weekly/test/weekly/...).
The root cause was the download + upload flow: remote content was first downloaded into the local backup directory, then the same directory was uploaded back to the same remote path, so mirrored subfolders could be re-uploaded repeatedly.
First run
'/environment/weekly/'
Second run
'/environment/weekly/environment/weekly/'
...
What was changed
Added path-safety logic to prevent recursive re-upload of the downloaded remote mirror when nested remote paths are used.