feat: Add BLOBXFER_REMOTE_DOWNLOAD flag#475
Open
eoehen wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #474
This PR introduces a new Blobxfer runtime flag to make remote pre-sync optional while keeping current behavior as the default.
Summary
Added BLOBXFER_REMOTE_DOWNLOAD with default TRUE.
When TRUE, the backup flow performs a remote download before upload (current sync behavior).
When FALSE, the remote pre-download step is skipped.
Why
Some deployments want upload-only behavior and do not need a remote-to-local sync before each backup run.
This flag provides explicit control without changing existing defaults.
Behavior and safety
Backward compatibility is preserved: default remains TRUE.
If remote download is disabled, remote cleanup sync is intentionally skipped to avoid delete operations without a synchronized local view.
This PR is based on the Blobxfer path-recursion fix PR and reuses that updated flow.
Configuration
Global: DEFAULT_BLOBXFER_REMOTE_DOWNLOAD=TRUE|FALSE
Per job: DBxx_BLOBXFER_REMOTE_DOWNLOAD=TRUE|FALSE (for example DB01_BLOBXFER_REMOTE_DOWNLOAD)
Docs and examples
Documentation updated to describe the new flag, default, and expected behavior.
Blobxfer compose example updated to include the new variable.
Testing notes
Verified default path (TRUE) keeps existing sync-first behavior.
Verified FALSE skips pre-download and still uploads current backup artifacts as expected.