Enabled as many warnings as possible and marked them as error.

Fixes #12.

Author: nfrechette

cmake/CMakeCompiler.cmake

@@ -3,15 +3,11 @@ cmake_minimum_required (VERSION 3.2)
 macro(setup_default_compiler_flags _project_name)
 	if(MSVC)
 		# Replace some default compiler switches and add new ones
-		STRING(REPLACE "/GR" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})		# Disable RTTI
-		STRING(REPLACE "/W3" "/W4" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})	# Bump warnings to W4
+		STRING(REPLACE "/GR" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})			# Disable RTTI
+		STRING(REPLACE "/W3" "/W4" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})		# Bump warnings to W4
 		target_compile_options(${_project_name} PRIVATE /Zi)				# Add debug info
 		target_compile_options(${_project_name} PRIVATE /Oi)				# Generate intrinsic functions
-
-		# Disable some warnings
-		target_compile_options(${_project_name} PRIVATE /wd4100)			# unreferenced formal parameter
-		target_compile_options(${_project_name} PRIVATE /wd4324)			# structure was padded due to alignment specified
-		target_compile_options(${_project_name} PRIVATE /wd4127)			# conditional expression is constant
+		target_compile_options(${_project_name} PRIVATE /WX)				# Treat warnings as errors
 
 		if(MSVC_VERSION GREATER 1900)
 			# VS2017 and above
@@ -29,5 +25,8 @@ macro(setup_default_compiler_flags _project_name)
 			target_compile_options(${_project_name} PRIVATE "-m64")
 			target_link_libraries(${_project_name} PRIVATE "-m64")
 		endif()
+
+		target_compile_options(${_project_name} PRIVATE -Wall)				# Enable all warnings
+		target_compile_options(${_project_name} PRIVATE -Werror)			# Treat warnings as errors
 	endif()
 endmacro()

includes/sjson/error.h

@@ -71,6 +71,10 @@
 		{
 			inline void on_assert_abort(const char* expression, int line, const char* file, const char* format, ...)
 			{
+				(void)expression;
+				(void)line;
+				(void)file;
+
 				va_list args;
 				va_start(args, format);
 
@@ -100,6 +104,10 @@
 		{
 			inline void on_assert_throw(const char* expression, int line, const char* file, const char* format, ...)
 			{
+				(void)expression;
+				(void)line;
+				(void)file;
+
 				constexpr int buffer_size = 64 * 1024;
 				char buffer[buffer_size];
 

includes/sjson/writer.h

@@ -68,6 +68,7 @@ namespace sjson
 
 		virtual void write(const void* buffer, size_t buffer_size) override
 		{
+			(void)buffer_size;
 			fprintf(m_file, "%s", reinterpret_cast<const char*>(buffer));
 		}
 

tests/sources/test_writer.cpp

@@ -331,7 +331,7 @@ TEST_CASE("Writer Object Array Writing", "[writer]")
 	{
 		StringStreamWriter str_writer;
 		Writer writer(str_writer);
-		writer.insert("key", [](ArrayWriter& array_writer)
+		writer.insert("key", [](ArrayWriter& /*array_writer*/)
 		{
 		});
 		REQUIRE(str_writer.str() == "key = [  ]\r\n");
@@ -365,7 +365,7 @@ TEST_CASE("Writer Object Object Writing", "[writer]")
 	{
 		StringStreamWriter str_writer;
 		Writer writer(str_writer);
-		writer.insert("key", [](ObjectWriter& object_writer)
+		writer.insert("key", [](ObjectWriter& /*object_writer*/)
 		{
 		});
 		REQUIRE(str_writer.str() == "key = {\r\n}\r\n");
@@ -598,7 +598,7 @@ TEST_CASE("Writer Array Array Writing", "[writer]")
 		Writer writer(str_writer);
 		writer.insert("key", [](ArrayWriter& array_writer)
 		{
-			array_writer.push([](ArrayWriter& array_writer)
+			array_writer.push([](ArrayWriter& /*array_writer*/)
 			{
 			});
 		});
@@ -627,7 +627,7 @@ TEST_CASE("Writer Array Object Writing", "[writer]")
 		Writer writer(str_writer);
 		writer.insert("key", [](ArrayWriter& array_writer)
 		{
-			array_writer.push([](ObjectWriter& object_writer)
+			array_writer.push([](ObjectWriter& /*object_writer*/)
 			{
 			});
 		});