Skip to content

Commit 9a58e9a

Browse files
committed
fix: disable versioned namespace by default for now
1 parent b6723ea commit 9a58e9a

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

includes/sjson/version.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,11 @@
5252
// Name of the namespace, e.g. v08
5353
#define SJSON_CPP_IMPL_VERSION_NAMESPACE_NAME v ## SJSON_CPP_VERSION_MAJOR ## SJSON_CPP_VERSION_MINOR
5454

55-
#if defined(SJSON_CPP_NO_VERSION_NAMESPACE)
55+
// Because this is being introduced in a patch release, as caution, it is disabled
56+
// by default. It does break ABI if host runtimes forward declare types but that
57+
// is something they shouldn't do with a 3rd party library. Now, we offer forward
58+
// declaration headers to help prepare the migration in the next minor release.
59+
#if defined(SJSON_CPP_NO_VERSION_NAMESPACE) || !defined(SJSON_CPP_ENABLE_VERSION_NAMESPACE)
5660
// Namespace is inlined, its usage does not need to be qualified with the
5761
// full version everywhere
5862
#define SJSON_CPP_IMPL_NAMESPACE sjson

0 commit comments

Comments
 (0)