Merge pull request #82 from spokodev/fix/hunt

fix: don't throw when a set-cookie string has no name-value-pair

Author: nfriedly

lib/set-cookie.js

@@ -21,6 +21,9 @@ function parseString(setCookieValue, options) {
   var parts = setCookieValue.split(";").filter(isNonEmptyString);
 
   var nameValuePairStr = parts.shift();
+  if (!nameValuePairStr) {
+    return null;
+  }
   var parsed = parseNameValuePair(nameValuePairStr);
   var name = parsed.name;
   var value = parsed.value;

test/set-cookie-parser.js

@@ -233,6 +233,15 @@ describe("set-cookie-parser", function () {
     assert.deepEqual(actual, expected);
   });
 
+  it("should ignore a set-cookie string with no name-value-pair instead of throwing", function () {
+    assert.deepEqual(parseSetCookie(";"), []);
+    assert.deepEqual(parseSetCookie("   ;   "), []);
+    assert.deepEqual(parseSetCookie([";", "foo=bar"]), [
+      { name: "foo", value: "bar" },
+    ]);
+    assert.deepEqual(parseSetCookie(";", { map: true }), {});
+  });
+
   it("should skip cookies that could pollute the object prototype", function () {
     var actual = parseSetCookie("__proto__=test;");
     var expected = [];