chore(cmake): standardize variable naming and packaging configuration

Author: ronan-fdev

README.md

@@ -187,7 +187,7 @@ The complete API documentation is available online at:
 cmake .. -DCMAKE_BUILD_TYPE=Release -DNFX_STRINGBUILDER_BUILD_DOCUMENTATION=ON
 
 # Build the documentation
-cmake --build . --target documentation
+cmake --build . --target nfx-stringbuilder-documentation
 ```
 
 #### Requirements

benchmark/CMakeLists.txt

@@ -15,17 +15,17 @@ endif()
 # Benchmarks source files
 #----------------------------------------------
 
-set(BENCHMARK_SOURCES)
+set(benchmark_sources)
 
-list(APPEND BENCHMARK_SOURCES
+list(APPEND benchmark_sources
 	BM_StringBuilder.cpp
 )
 
 #----------------------------------------------
 # Configure benchmark executables
 #----------------------------------------------
 
-foreach(benchmark_source ${BENCHMARK_SOURCES})
+foreach(benchmark_source ${benchmark_sources})
 	get_filename_component(benchmark_target_name ${benchmark_source} NAME_WE)
 	if(NOT TARGET ${benchmark_target_name})
 		add_executable(${benchmark_target_name} ${benchmark_source})
@@ -39,15 +39,6 @@ foreach(benchmark_source ${BENCHMARK_SOURCES})
 			benchmark::benchmark
 		)
 
-		#----------------------------------------------
-		# Enable specific CPU features
-		#----------------------------------------------
-
-		target_compile_options(${benchmark_target_name} PRIVATE
-			$<$<CXX_COMPILER_ID:MSVC>:/arch:AVX2>
-			$<$<OR:$<CXX_COMPILER_ID:GNU>,$<CXX_COMPILER_ID:Clang>>:-msse4.2>
-		)
-
 		#----------------------------------------------
 		# Properties
 		#----------------------------------------------

cmake/nfx-stringbuilder-config.cmake.in

@@ -26,8 +26,6 @@ set(NFX_STRINGBUILDER_VERSION_PATCH "@PROJECT_VERSION_PATCH@")
 set_and_check(NFX_STRINGBUILDER_INCLUDE_DIR "@PACKAGE_CMAKE_INSTALL_INCLUDEDIR@")
 set_and_check(NFX_STRINGBUILDER_LIB_DIR "@PACKAGE_CMAKE_INSTALL_LIBDIR@")
 
-# Our library dependencies (none - self-contained library)
-
 # Include the targets file
 include("${CMAKE_CURRENT_LIST_DIR}/nfx-stringbuilder-targets.cmake")
 

cmake/nfxStringBuilderBuildConfig.cmake

@@ -59,7 +59,7 @@ include(GNUInstallDirs)
 # Directory configuration
 #----------------------------------------------
 
-set(NFX_STRINGBUILDER_DIR          "${PROJECT_SOURCE_DIR}"        CACHE PATH  "Root directory"   )
+set(NFX_STRINGBUILDER_DIR          "${PROJECT_SOURCE_DIR}"             CACHE PATH  "Root directory"   )
 set(NFX_STRINGBUILDER_INCLUDE_DIR  "${NFX_STRINGBUILDER_DIR}/include"  CACHE PATH  "Include directory")
 set(NFX_STRINGBUILDER_SOURCE_DIR   "${NFX_STRINGBUILDER_DIR}/src"      CACHE PATH  "Source directory" )
 

cmake/nfxStringBuilderDependencies.cmake

@@ -2,9 +2,9 @@
 # nfx-stringbuilder - Dependencies configuration
 #==============================================================================
 
-#----------------------------
+#----------------------------------------------
 # Output configuration
-#----------------------------
+#----------------------------------------------
 
 set(_SAVED_CMAKE_REQUIRED_QUIET     ${CMAKE_REQUIRED_QUIET})
 set(_SAVED_CMAKE_MESSAGE_LOG_LEVEL  ${CMAKE_MESSAGE_LOG_LEVEL})
@@ -83,9 +83,9 @@ if(NFX_STRINGBUILDER_BUILD_BENCHMARKS)
 	endif()
 endif()
 
-#----------------------------
+#----------------------------------------------
 # Dependency fetching
-#----------------------------
+#----------------------------------------------
 
 if(NFX_STRINGBUILDER_BUILD_TESTS)
 	if(NOT GTest_FOUND)
@@ -99,9 +99,9 @@ if(NFX_STRINGBUILDER_BUILD_BENCHMARKS)
 	endif()
 endif()
 
-#----------------------------
+#----------------------------------------------
 # Cleanup
-#----------------------------
+#----------------------------------------------
 
 set(CMAKE_REQUIRED_QUIET ${_SAVED_CMAKE_REQUIRED_QUIET})
 set(CMAKE_MESSAGE_LOG_LEVEL ${_SAVED_CMAKE_MESSAGE_LOG_LEVEL})

cmake/nfxStringBuilderInstall.cmake

@@ -39,19 +39,19 @@ install(
 # Install library targets
 #----------------------------------------------
 
-set(INSTALL_TARGETS)
+set(install_targets)
 
 if(NFX_STRINGBUILDER_BUILD_SHARED)
-	list(APPEND INSTALL_TARGETS ${PROJECT_NAME})
+	list(APPEND install_targets ${PROJECT_NAME})
 endif()
 
 if(NFX_STRINGBUILDER_BUILD_STATIC)
-	list(APPEND INSTALL_TARGETS ${PROJECT_NAME}-static)
+	list(APPEND install_targets ${PROJECT_NAME}-static)
 endif()
 
-if(INSTALL_TARGETS)
+if(install_targets)
 	install(
-		TARGETS ${INSTALL_TARGETS}
+		TARGETS ${install_targets}
 		EXPORT nfx-stringbuilder-targets
 		ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
 			COMPONENT Development
@@ -173,4 +173,4 @@ if(NFX_STRINGBUILDER_BUILD_DOCUMENTATION)
 	endif()
 endif()
 
-message(STATUS "Installation configured for targets: ${INSTALL_TARGETS}")
+message(STATUS "Installation configured for targets: ${install_targets}")

cmake/nfxStringBuilderPackaging.cmake

@@ -21,9 +21,9 @@ endif()
 
 # --- Detect processor count for parallel packaging ---
 include(ProcessorCount)
-ProcessorCount(N)
-if(NOT N EQUAL 0)
-	set(CPACK_THREADS ${N})
+ProcessorCount(processor_count)
+if(NOT processor_count EQUAL 0)
+	set(CPACK_THREADS ${processor_count})
 else()
 	set(CPACK_THREADS 1)
 endif()
@@ -90,6 +90,19 @@ set(CPACK_PACKAGE_INSTALL_REGISTRY_KEY  "nfx-stringbuilder")
 # Platform-specific generators
 #----------------------------------------------
 
+# --- Find packaging tools ---
+if(UNIX AND NOT APPLE)
+	find_program(DPKG_CMD dpkg)
+	find_program(RPM_CMD rpm)
+endif()
+
+if(WIN32)
+	if(NOT WIX_CANDLE OR NOT WIX_LIGHT)
+		find_program(WIX_CANDLE NAMES candle.exe candle HINTS "$ENV{WIX}/bin")
+		find_program(WIX_LIGHT NAMES light.exe light HINTS "$ENV{WIX}/bin")
+	endif()
+endif()
+
 # --- Generators ---
 if(NOT DEFINED CPACK_GENERATOR)
 	set(CPACK_GENERATOR "")
@@ -105,7 +118,6 @@ if(NOT DEFINED CPACK_GENERATOR)
 
 	# --- DEB packages ---
 	if(NFX_STRINGBUILDER_PACKAGE_DEB AND UNIX AND NOT APPLE)
-		find_program(DPKG_CMD dpkg)
 		if(DPKG_CMD)
 			set(CPACK_GENERATOR "${CPACK_GENERATOR};DEB")
 		else()
@@ -115,7 +127,6 @@ if(NOT DEFINED CPACK_GENERATOR)
 
 	# --- RPM packages ---
 	if(NFX_STRINGBUILDER_PACKAGE_RPM AND UNIX AND NOT APPLE)
-		find_program(RPM_CMD rpm)
 		if(RPM_CMD)
 			set(CPACK_GENERATOR "${CPACK_GENERATOR};RPM")
 		else()
@@ -125,26 +136,11 @@ if(NOT DEFINED CPACK_GENERATOR)
 
 	# --- WiX packages ---
 	if(NFX_STRINGBUILDER_PACKAGE_WIX AND WIN32)
-		if(NOT WIX_CANDLE OR NOT WIX_LIGHT)
-			set(WIX_SEARCH_PATHS
-				"C:/Program Files (x86)/WiX Toolset v3.14/bin"
-				"C:/Program Files (x86)/WiX Toolset v3.11/bin"
-				"C:/Program Files (x86)/WiX Toolset v3.10/bin"
-				"$ENV{WIX}bin"
-			)
-			
-			find_program(WIX_CANDLE NAMES candle.exe candle PATHS ${WIX_SEARCH_PATHS} NO_DEFAULT_PATH)
-			find_program(WIX_LIGHT NAMES light.exe light PATHS ${WIX_SEARCH_PATHS} NO_DEFAULT_PATH)
-		endif()
-		
 		if(WIX_CANDLE AND WIX_LIGHT)
 			set(CPACK_GENERATOR "${CPACK_GENERATOR};WIX")
 			message(STATUS "WiX found: ${WIX_CANDLE} - Windows MSI installer generation enabled")
 		else()
-			message(STATUS "WiX not found - install WiX Toolset v3.x for MSI installer support")
-			if(DEFINED WIX_SEARCH_PATHS)
-				message(STATUS "  Searched paths: ${WIX_SEARCH_PATHS}")
-			endif()
+			message(STATUS "WiX not found - install WiX Toolset and ensure WIX environment variable is set")
 		endif()
 	endif()
 
@@ -162,13 +158,12 @@ message(STATUS "  Output dir: ${CPACK_PACKAGE_DIRECTORY}")
 
 if("DEB" IN_LIST CPACK_GENERATOR AND UNIX AND NOT APPLE)
 	if(NOT DEFINED CPACK_DEBIAN_PACKAGE_ARCHITECTURE)
-		find_program(DPKG_CMD dpkg)
 		if(DPKG_CMD)
 			execute_process(COMMAND ${DPKG_CMD} --print-architecture
-				OUTPUT_VARIABLE DETECTED_DEB_ARCH
+				OUTPUT_VARIABLE detected_deb_arch
 				OUTPUT_STRIP_TRAILING_WHITESPACE
 				ERROR_QUIET)
-			set(CPACK_DEBIAN_PACKAGE_ARCHITECTURE "${DETECTED_DEB_ARCH}")
+			set(CPACK_DEBIAN_PACKAGE_ARCHITECTURE "${detected_deb_arch}")
 		endif()
 	endif()
 
@@ -178,10 +173,10 @@ endif()
 if("RPM" IN_LIST CPACK_GENERATOR AND UNIX AND NOT APPLE)
 	if(NOT DEFINED CPACK_RPM_PACKAGE_ARCHITECTURE)
 		execute_process(COMMAND uname -m
-			OUTPUT_VARIABLE DETECTED_RPM_ARCH
+			OUTPUT_VARIABLE detected_rpm_arch
 			OUTPUT_STRIP_TRAILING_WHITESPACE
 			ERROR_QUIET)
-		set(CPACK_RPM_PACKAGE_ARCHITECTURE "${DETECTED_RPM_ARCH}")
+		set(CPACK_RPM_PACKAGE_ARCHITECTURE "${detected_rpm_arch}")
 	endif()
 
 	message(STATUS "RPM package architecture: ${CPACK_RPM_PACKAGE_ARCHITECTURE}")
@@ -203,12 +198,7 @@ if("DEB" IN_LIST CPACK_GENERATOR AND UNIX AND NOT APPLE)
 	set(CPACK_DEBIAN_COMPRESSION_TYPE      "xz")
 	set(CPACK_DEBIAN_PACKAGE_PRIORITY      "optional")
 	set(CPACK_DEBIAN_PACKAGE_HOMEPAGE      ${CPACK_PACKAGE_HOMEPAGE_URL})
-	
-	# --- Core runtime dependencies  ---
-	set(DEB_DEPENDS "libc6, libstdc++6, libgcc-s1")
-	
-	set(CPACK_DEBIAN_PACKAGE_DEPENDS "${DEB_DEPENDS}")
-	message(STATUS "DEB dependencies: ${CPACK_DEBIAN_PACKAGE_DEPENDS}")
+	set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS     ON)
 endif()
 
 # --- RPM package settings ---
@@ -225,12 +215,7 @@ if("RPM" IN_LIST CPACK_GENERATOR AND UNIX AND NOT APPLE)
 	set(CPACK_RPM_PACKAGE_VENDOR        ${CPACK_PACKAGE_VENDOR})
 	set(CPACK_RPM_PACKAGE_DESCRIPTION   ${PROJECT_DESCRIPTION})
 	set(CPACK_RPM_PACKAGE_URL           ${CPACK_PACKAGE_HOMEPAGE_URL})
-
-	# --- Core runtime dependencies ---
-	set(RPM_REQUIRES "glibc, libstdc++")
-	
-	set(CPACK_RPM_PACKAGE_REQUIRES "${RPM_REQUIRES}")
-	message(STATUS "RPM dependencies: ${CPACK_RPM_PACKAGE_REQUIRES}")
+	set(CPACK_RPM_PACKAGE_AUTOREQ       ON)
 endif()
 
 #----------------------------------------------

cmake/nfxStringBuilderSources.cmake

@@ -6,9 +6,9 @@
 # Source files
 #----------------------------------------------
 
-set(PRIVATE_SOURCES)
+set(private_sources)
 
-list(APPEND PRIVATE_SOURCES
+list(APPEND private_sources
 	${NFX_STRINGBUILDER_SOURCE_DIR}/DynamicStringBufferPool.cpp
 	${NFX_STRINGBUILDER_SOURCE_DIR}/StringBuilder.cpp
 )

cmake/nfxStringBuilderTargets.cmake

@@ -11,7 +11,7 @@ if(NFX_STRINGBUILDER_BUILD_SHARED)
 	add_library(${PROJECT_NAME} SHARED)
 	target_sources(${PROJECT_NAME}
 		PRIVATE
-			${PRIVATE_SOURCES}
+			${private_sources}
 	)
 
 	set_target_properties(${PROJECT_NAME} PROPERTIES
@@ -27,7 +27,7 @@ if(NFX_STRINGBUILDER_BUILD_STATIC)
 	add_library(${PROJECT_NAME}-static STATIC)
 	target_sources(${PROJECT_NAME}-static
 		PRIVATE
-			${PRIVATE_SOURCES}
+			${private_sources}
 	)
 
 	set_target_properties(${PROJECT_NAME}-static PROPERTIES

samples/CMakeLists.txt

@@ -15,17 +15,17 @@ endif()
 # Samples source files
 #----------------------------------------------
 
-set(SAMPLE_SOURCES)
+set(sample_sources)
 
-list(APPEND SAMPLE_SOURCES
+list(APPEND sample_sources
 	Sample_StringBuilder.cpp
 )
 
 #----------------------------------------------
 # Configure samples executables
 #----------------------------------------------
 
-foreach(sample_source ${SAMPLE_SOURCES})
+foreach(sample_source ${sample_sources})
 	get_filename_component(sample_target_name ${sample_source} NAME_WE)
 
 	if(NOT TARGET ${sample_target_name})
@@ -39,15 +39,6 @@ foreach(sample_source ${SAMPLE_SOURCES})
 			nfx-stringbuilder::static
 		)
 
-		#----------------------------------------------
-		# Enable specific CPU features
-		#----------------------------------------------
-
-		target_compile_options(${sample_target_name} PRIVATE
-			$<$<CXX_COMPILER_ID:MSVC>:/arch:AVX2>
-			$<$<OR:$<CXX_COMPILER_ID:GNU>,$<CXX_COMPILER_ID:Clang>>:-msse4.2>
-		)
-
 		#----------------------------------------------
 		# Properties
 		#----------------------------------------------