Skip to content

KMZ importing updated to support image uploads#298

Merged
ryanslatten merged 8 commits into
developfrom
kmz-upload
Jul 16, 2025
Merged

KMZ importing updated to support image uploads#298
ryanslatten merged 8 commits into
developfrom
kmz-upload

Conversation

@ryanslatten
Copy link
Copy Markdown
Contributor

@ryanslatten ryanslatten commented Jul 1, 2025

This PR fixes an issue with KMZ uploading where image files included are not being used resulting in a blank image displayed. This also fixes an issue where invalid images would be hidden instead of defaulting to the standard icon.

Example feature layer using features that reference a camera icon included in the KMZ.
Screenshot 2025-07-01 at 3 31 49 PM

To test: Import KMZ files that make use of images that are packaged in the KMZ file. Also ensure that features that reference an invalid image will fallback to the default icon.

A consideration that we may want to implement is to store icons separately in the geojson return value and have features point there to avoid duplication. Another option is to have an icon repository where all non http icons would be stored

Copy link
Copy Markdown
Contributor

@jmckomni jmckomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes. Reach out to me either in this PR or directly if you have concerns or questions.

Comment thread service/src/routes/imports.ts
Comment thread service/src/routes/imports.ts
Comment thread service/src/routes/imports.ts
Comment thread service/src/utilities/transformKML.ts Outdated
Comment thread service/src/utilities/transformKML.ts Outdated
Comment thread service/src/utilities/transformKML.ts
Comment thread service/src/utilities/transformKML.ts
@ryanslatten ryanslatten requested a review from jmckomni July 11, 2025 00:59
@ryanslatten ryanslatten merged commit a04001d into develop Jul 16, 2025
8 of 9 checks passed
@ryanslatten ryanslatten deleted the kmz-upload branch July 16, 2025 20:07
cwerthomni added a commit that referenced this pull request Aug 8, 2025
* update prod dockerfile and github actions

* Adds User and Form Selection to Filtering Options. Also Fixes the Time Based Filtering.

* Add Comments and a New Type

* Fix Variables

* added CODEOWNERS file.

* Fix Errors found by CJ

* KMZ importing updated to support image uploads (#298)

Improve KMZ file importing where observations with included images are not displayed properly

* moved CODEOWNERS to root of project.

* Homepage updated for support for smaller screens (#303)

* initial commit

* fix title styling

* updated css names

* Publish containers as packages (#304)

* update action to deploy container artifact

* update yml and action name

* Production Container action

* update containers and scripts

* update dev dockerfile

* update dockerfile

---------

Co-authored-by: Clinton Werth <clinton@Clintons-MacBook-Pro.local>

* Prod container action (#305)

* new docker file and update prod container action

* down to one dockerfile

---------

Co-authored-by: Clinton Werth <clinton@Clintons-MacBook-Pro.local>
Co-authored-by: Clinton Werth <clinton@MacBook-Pro.local>

* changed time format option from '30 seconds' to 'Relative'

* updated CODEOWNERS

* MOCKUP: Adding support for observations without geometry (#300)

Update the Observation logic to add a noGeometry flag.

* Admin Teams dashboard component upgrade from AngularJS to Angular 14 (#306)

Updates the Teams component to Angular 14

---------

Co-authored-by: Clinton Werth <clinton@MacBook-Pro.local>

* authorization component now submits access code when user hits enter.

* Initial Commit, ts and html changes

* Hook Up Module

* fix modules

* Remove and Revert

* fixes

* directive

* include module

* Pushing latest changes

* Final Commit

* fix css

* Remove DS Store Files

* Make HTML Safe Again

* unknown device

* fix package log

* Updates for 6.4.0-beta.2 release (#311)

Co-authored-by: Clinton Werth <clinton@MacBook-Pro.local>

---------

Co-authored-by: Clinton Werth <clinton@Clintons-MacBook-Pro.local>
Co-authored-by: Ryan Carpenter <ryan.carpenter@omnifederal.com>
Co-authored-by: John McKeever <johnmckeever@Johns-MacBook-Pro.local>
Co-authored-by: jmckomni <john.mckeever@omnifederal.com>
Co-authored-by: Ryan <46985385+ryanslatten@users.noreply.github.com>
Co-authored-by: Clinton Werth <clinton@MacBook-Pro.local>
Co-authored-by: MilliannaMiodori <cozycollectorclub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants