Skip to content

Update and Fix Observation Filtering - MAGE-1501#299

Merged
RyCarpenter merged 4 commits into
developfrom
feature/MAGE-1501-Filtering
Jul 22, 2025
Merged

Update and Fix Observation Filtering - MAGE-1501#299
RyCarpenter merged 4 commits into
developfrom
feature/MAGE-1501-Filtering

Conversation

@RyCarpenter
Copy link
Copy Markdown
Contributor

This PR Fixes the Date Based Filtering for Observations, as well as adds two new Options {User, Form} to choose from.

image

Test Instructions:

Before Testing, you will need a server that has multiple observations, with multiple forms, and multiple users.

  1. Log into Mage
  2. On the Map Page Click the Filter Funnel Button in the upper left
  3. Set Filter Options To Your Liking (Event, Teams, User, Forms, Time)
  4. Click Filter
  5. Expected result is that your Observations are Filtered in based on your selections.
  6. Play around with different combinations, All combinations should work.
  7. Change Events
  8. All Filters should clear
  9. Try to filter on the new event

danbenner-vega
danbenner-vega previously approved these changes Jul 9, 2025
Copy link
Copy Markdown
Contributor

@danbenner-vega danbenner-vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

paulsolt-ofsw
paulsolt-ofsw previously approved these changes Jul 9, 2025
Copy link
Copy Markdown
Contributor

@paulsolt-ofsw paulsolt-ofsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. I tested this locally and it worked.

  1. I would separate style changes from the actual fix (if possible) so that it's easier to grok what the problem was.
  2. I can't tell if it was in the html component or filter.component.ts or somewhere else with all the function style changes. Could you direct me to where I should look at code?
  3. We do have a filter issue, that prevents Forms from loading after you press "Filter" on the filter screen. That's an existing bug, but related to the user experience of filtering (on Chrome/Safari).
  4. I had one instance where it appears my observation didn't get saved, and so it was not working with the filter. I don't know if that's an existing bug or weird state from turning on/off several filters. We we're not able to replicate that situation on Safari again.

Comment thread service/src/api/observation.js
Comment thread service/src/api/observation.js
Comment thread service/src/api/observation.js
Comment thread service/src/api/observation.js
Comment thread web-app/src/app/filter/filter.component.ts Outdated
Comment thread web-app/src/app/filter/filter.service.ts Outdated
Comment thread web-app/src/app/filter/filter.service.ts Outdated
Comment thread web-app/src/app/filter/filter.service.ts
jmckomni
jmckomni previously approved these changes Jul 10, 2025
@RyCarpenter RyCarpenter merged commit 344c3bc into develop Jul 22, 2025
8 checks passed
@RyCarpenter RyCarpenter deleted the feature/MAGE-1501-Filtering branch July 22, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants