Update and Fix Observation Filtering - MAGE-1501#299
Merged
Conversation
paulsolt-ofsw
previously approved these changes
Jul 9, 2025
Contributor
paulsolt-ofsw
left a comment
There was a problem hiding this comment.
Overall it looks good. I tested this locally and it worked.
- I would separate style changes from the actual fix (if possible) so that it's easier to grok what the problem was.
- I can't tell if it was in the html component or filter.component.ts or somewhere else with all the function style changes. Could you direct me to where I should look at code?
- We do have a filter issue, that prevents Forms from loading after you press "Filter" on the filter screen. That's an existing bug, but related to the user experience of filtering (on Chrome/Safari).
- I had one instance where it appears my observation didn't get saved, and so it was not working with the filter. I don't know if that's an existing bug or weird state from turning on/off several filters. We we're not able to replicate that situation on Safari again.
jmckomni
reviewed
Jul 10, 2025
jmckomni
reviewed
Jul 10, 2025
jmckomni
reviewed
Jul 10, 2025
jmckomni
reviewed
Jul 10, 2025
jmckomni
previously approved these changes
Jul 10, 2025
54ede4b
danbenner-vega
approved these changes
Jul 17, 2025
cwerthomni
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Fixes the Date Based Filtering for Observations, as well as adds two new Options {User, Form} to choose from.
Test Instructions:
Before Testing, you will need a server that has multiple observations, with multiple forms, and multiple users.