Skip to content

Explicit forward proxy support for HTTP with Basic Auth#1201

Merged
Akshay2191 merged 22 commits into
mainfrom
add-explicit-forward-proxy
Aug 26, 2025
Merged

Explicit forward proxy support for HTTP with Basic Auth#1201
Akshay2191 merged 22 commits into
mainfrom
add-explicit-forward-proxy

Conversation

@Akshay2191

@Akshay2191 Akshay2191 commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@Akshay2191 Akshay2191 requested a review from a team as a code owner August 7, 2025 16:26
@github-actions github-actions Bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Aug 7, 2025
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Aug 8, 2025
dhurley
dhurley reviewed Aug 8, 2025
View reviewed changes
Comment thread PROXY_SUPPORT.md Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go
Comment thread internal/config/types.go Outdated
Comment thread internal/grpc/proxy_dialer.go
Comment thread internal/collector/otel_collector_plugin.go Outdated
aphralG
aphralG reviewed Aug 11, 2025
View reviewed changes
Comment thread internal/collector/otel_collector_plugin.go
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/grpc/proxy_dialer.go
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
@Akshay2191 Akshay2191 requested review from aphralG and dhurley August 11, 2025 11:13
craigell
craigell reviewed Aug 15, 2025
View reviewed changes
Comment thread internal/config/config.go
dhurley
dhurley reviewed Aug 20, 2025
View reviewed changes
Comment thread PROXY_SUPPORT.md Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin.go Outdated
Comment thread internal/collector/otel_collector_plugin_test.go Outdated
@Akshay2191 Akshay2191 requested a review from dhurley August 20, 2025 13:46
dhurley
dhurley reviewed Aug 22, 2025
View reviewed changes
Comment thread internal/collector/otel_collector_plugin.go
Comment thread internal/config/types.go Outdated
aphralG
aphralG reviewed Aug 22, 2025
View reviewed changes
Comment thread internal/config/types.go Outdated
aphralG
aphralG reviewed Aug 25, 2025
View reviewed changes
Comment thread internal/collector/otel_collector_plugin_test.go Outdated
Comment thread internal/grpc/proxy_dialer.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
Comment thread internal/grpc/proxy_dialer_test.go Outdated
@Akshay2191 Akshay2191 merged commit cad7b8c into main Aug 26, 2025
26 checks passed
@Akshay2191 Akshay2191 deleted the add-explicit-forward-proxy branch August 26, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhurley dhurley dhurley approved these changes
@craigell craigell craigell approved these changes
+1 more reviewer
@aphralG aphralG aphralG approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Akshay2191 @dhurley @craigell @aphralG