Skip to content

Commit 5e0d6fd

Browse files
committed
Add_link_options mwindows on GCC windows
1 parent 42e0124 commit 5e0d6fd

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/build-windows.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,6 @@ jobs:
8686
name: ngscopeclient-build-windows-${{ runner.os }}-${{ matrix.env }}-${{ github.job }}
8787
path: build
8888

89-
# - name: Upload Artifacts
90-
# uses: actions/upload-artifact@v4
91-
# with:
92-
# name: glscopeclient-windows-${{ runner.os }}-${{ github.job }}
93-
# path: msys2/*.zst
94-
9589
- name: Upload Artifacts (ngscopeclient portable zip)
9690
if: ${{ matrix.sys == 'ucrt64' }}
9791
uses: actions/upload-artifact@v4

src/ngscopeclient/CMakeLists.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,13 @@ endif()
2525
if(WIN32)
2626
if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
2727
add_link_options(-Wl,/SUBSYSTEM:WINDOWS)
28+
message(STATUS "using Clang on windows, setting win32 subsystem via linker option")
2829
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
30+
message(STATUS "Using gcc on windows, setting -mwindows to use win32 subsystem")
2931
add_compile_options(-mwindows)
32+
add_link_options(-mwindows)
33+
else()
34+
message(STATUS "Unknown windows compiler")
3035
endif()
3136
endif()
3237

0 commit comments

Comments
 (0)