Skip to content

Commit 798acc9

Browse files
committed
Fixed bug where WaveformArea would fail to autoscale the Y axis if the waveform was only in GPU memory and there was no up to date copy on the CPU
1 parent fa40081 commit 798acc9

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

release-notes/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ We try to maintain compatibility with older versions of ngscopeclient but occasi
2222

2323
## Bugs fixed since v0.1.1
2424

25-
* PcapNG export did not handle named pipes correctly (no github ticket)
25+
* Filters: PcapNG export did not handle named pipes correctly (no github ticket)
26+
* GUI: Pressing middle mouse on the Y axis to autoscale would fail, setting the full scale range to zero volts, if the waveform was resident in GPU memory and the CPU-side copy of the buffer was stale
2627

2728
## Other changes since v0.1.1

src/ngscopeclient/WaveformArea.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2745,6 +2745,7 @@ void WaveformArea::RenderYAxis(ImVec2 size, map<float, float>& gridmap, float vb
27452745
for(auto& c : m_displayedChannels)
27462746
{
27472747
auto data = c->GetStream().GetData();
2748+
data->PrepareForCpuAccess();
27482749
auto sdata = dynamic_cast<SparseAnalogWaveform*>(data);
27492750
auto udata = dynamic_cast<UniformAnalogWaveform*>(data);
27502751
if(!sdata && !udata)

0 commit comments

Comments
 (0)