Updated to latest scopehal with bug fixes and filter error reporting support. Began work on filter error reporting in graph editor.

Author: azonenberg

lib

@@ -15,6 +15,7 @@ This is a running list of significant bug fixes and new features since the last
 * Filters: Horizontal bathtub curve now works properly with MLT-3 / PAM-3 eyes as well as NRZ. No PAM-4 or higher support yet.
 * Filters: PcapNG export now has an additional mode selector for use with named pipes, allowing live streaming of PcapNG formatted data to WireShark
 * GUI: enabled mouseover BER measurements on MLT-3 / PAM-3 eyes as well as NRZ. No PAM-4 or higher support yet.
+* GUI: Filter graph editor now allows filters and instrument channels to display error messages when their configuration is invalid or something goes wrong. Not all drivers/filters take advantage of this yet.
 
 ## Breaking changes since v0.1.1
 
@@ -35,6 +36,7 @@ We try to maintain compatibility with older versions of ngscopeclient but occasi
 * GUI: Crash when closing a session (https://github.com/ngscopeclient/scopehal-apps/issues/934)
 * GUI: Pressing middle mouse on the Y axis to autoscale would fail, setting the full scale range to zero volts, if the waveform was resident in GPU memory and the CPU-side copy of the buffer was stale
 * GUI: History dialog allowed zero or negative values for history depth (https://github.com/ngscopeclient/scopehal-apps/issues/940)
+* Session files: Windows build could not load session files containing sample rates or memory depths in excess of 2^32
 
 ## Other changes since v0.1.1
 

release-notes/CHANGELOG.md

@@ -2,7 +2,7 @@
 *                                                                                                                      *
 * ngscopeclient                                                                                                        *
 *                                                                                                                      *
-* Copyright (c) 2012-2025 Andrew D. Zonenberg and contributors                                                         *
+* Copyright (c) 2012-2026 Andrew D. Zonenberg and contributors                                                         *
 * All rights reserved.                                                                                                 *
 *                                                                                                                      *
 * Redistribution and use in source and binary forms, with or without modification, are permitted provided that the     *
@@ -2197,29 +2197,29 @@ void FilterGraphEditor::DoNodeForChannel(
 	//TODO: add an option for toggling this
 	//TODO: add preference for colors
 	//Draw a bubble above the text with the runtime stats
+	float messageSpacing = 0.1 * headerheight;
+	float nextIconBot = pos.y - messageSpacing;
 	if(runtime > 0)
 	{
 		auto runtimeText = fs.PrettyPrint(runtime, 3);
 		auto runtimeSize = ImGui::CalcTextSize(runtimeText.c_str());
 
 		auto timebgColor = ColorFromString("#404040");
 		auto timeTextColor = ColorFromString("#ffffff");
-		float timespacing = 0.1 * headerheight;
-		float runtimeBot = pos.y - timespacing;
 		float bubbleHeight = runtimeSize.y + 2*ImGui::GetStyle().FramePadding.y;
 
 		ImVec2 clockiconpos(
 			pos.x + ImGui::GetStyle().FramePadding.x,
-			runtimeBot - bubbleHeight + ImGui::GetStyle().FramePadding.y);
+			nextIconBot - bubbleHeight + ImGui::GetStyle().FramePadding.y);
 		ImVec2 clockiconsize(runtimeSize.y, runtimeSize.y);
 
 		ImVec2 textpos(
 			clockiconpos.x + clockiconsize.x + ImGui::GetStyle().ItemSpacing.x,
 			clockiconpos.y );
 
 		bgList->AddRectFilled(
-			ImVec2(pos.x + 1, runtimeBot - bubbleHeight),
-			ImVec2(textpos.x + runtimeSize.x + ImGui::GetStyle().FramePadding.y, runtimeBot),
+			ImVec2(pos.x + 1, nextIconBot - bubbleHeight),
+			ImVec2(textpos.x + runtimeSize.x + ImGui::GetStyle().FramePadding.y, nextIconBot),
 			timebgColor,
 			rounding,
 			ImDrawFlags_RoundCornersAll);
@@ -2233,7 +2233,50 @@ void FilterGraphEditor::DoNodeForChannel(
 			textpos,
 			timeTextColor,
 			runtimeText.c_str());
+
+		nextIconBot -= runtimeSize.y + 3*messageSpacing;
+	}
+
+	//Display errors
+	if(channel->HasErrors())
+	{
+		auto errorText = /*channel->GetErrorLog()*/ string("ERROR");
+		auto errorSize = ImGui::CalcTextSize(errorText.c_str());
+
+		//TODO: preferences?
+		auto bgColor = ColorFromString("#404040");
+		auto textColor = ColorFromString("#ffffff");
+		float bubbleHeight = errorSize.y + 2*ImGui::GetStyle().FramePadding.y;
+
+		ImVec2 erriconpos(
+			pos.x + ImGui::GetStyle().FramePadding.x,
+			nextIconBot - bubbleHeight + ImGui::GetStyle().FramePadding.y);
+		ImVec2 erriconsize(errorSize.y, errorSize.y);
+
+		ImVec2 textpos(
+			erriconpos.x + erriconsize.x + ImGui::GetStyle().ItemSpacing.x,
+			erriconpos.y );
+
+		bgList->AddRectFilled(
+			ImVec2(pos.x + 1, nextIconBot - bubbleHeight),
+			ImVec2(textpos.x + errorSize.x + ImGui::GetStyle().FramePadding.y, nextIconBot),
+			bgColor,
+			rounding,
+			ImDrawFlags_RoundCornersAll);
+
+		bgList->AddImage(
+			m_parent->GetTextureManager()->GetTexture("error"),
+			erriconpos,
+			erriconpos + erriconsize );
+
+		bgList->AddText(
+			textpos,
+			textColor,
+			errorText.c_str());
+
+		nextIconBot -= errorSize.y + 3*messageSpacing;
 	}
+
 	ImGui::PopFont(); // headerfont
 
 	//Draw the force vector