Skip to content

Commit f74ef1a

Browse files
committed
LogViewerDialog: properly enable/disable tracing when adding first / removing last trace filter
1 parent 94b46e8 commit f74ef1a

1 file changed

Lines changed: 18 additions & 0 deletions

File tree

src/ngscopeclient/LogViewerDialog.cpp

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,28 @@ bool LogViewerDialog::DoRender()
140140
{
141141
g_trace_filters.emplace(m_traceFilter);
142142
m_traceFilter = "";
143+
144+
//Enable tracing if it wasn't on already
145+
if(g_guiLog->GetSeverity() != Severity::TRACE)
146+
{
147+
g_guiLog->SetSeverity(Severity::TRACE);
148+
m_severityFilter = Severity::TRACE;
149+
m_displayedSeverity = static_cast<int>(Severity::TRACE) - 1;
150+
}
143151
}
144152
ImGui::SameLine();
145153
if(ImGui::Button("-"))
154+
{
146155
g_trace_filters.erase(m_selectedFilter);
156+
157+
//Turn tracing off if we're removing the last trace filter
158+
if(g_trace_filters.empty())
159+
{
160+
g_guiLog->SetSeverity(Severity::DEBUG);
161+
m_severityFilter = Severity::DEBUG;
162+
m_displayedSeverity = static_cast<int>(Severity::DEBUG) - 1;
163+
}
164+
}
147165
}
148166

149167
auto font = m_parent->GetFontPref("Appearance.General.console_font");

0 commit comments

Comments
 (0)