Skip to content

Use ImGui's native DPI scaling. #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azonenberg merged 1 commit into from
Sep 23, 2025
Merged

Use ImGui's native DPI scaling. #902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions src/ngscopeclient/VulkanWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ VulkanWindow::VulkanWindow(const string& title, shared_ptr<QueueHandle> queue)
io.ConfigFlags |= ImGuiConfigFlags_NavEnableKeyboard;
io.ConfigFlags |= ImGuiConfigFlags_DockingEnable;
io.ConfigFlags |= ImGuiConfigFlags_ViewportsEnable;
io.ConfigDpiScaleFonts = true;
io.ConfigDpiScaleViewports = true;

//Don't serialize UI config for now
//TODO: serialize to scopesession or something? https://github.com/ocornut/imgui/issues/4294
Expand Down Expand Up @@ -182,18 +184,6 @@ VulkanWindow::VulkanWindow(const string& title, shared_ptr<QueueHandle> queue)
ImGui_ImplVulkan_Init(&info);
}

//Apply DPI scaling now that glfw initialized
//This appears to be cached by glfw at init time and is not updated for dynamic scaling changes at least on X11
//TODO: can we fix this by moving to SDL?
float scale = GetContentScale();
LogTrace("Using ImGui style scale factor: %.2f\n", scale);

//Per comment in imgui_impl_glfw "Apple platforms use FramebufferScale"
//On everything else use FontScaleMain
#ifndef __APPLE__
ImGui::GetStyle().FontScaleMain = scale;
#endif

//Hook a couple of backend functions with mutexing
ImGuiPlatformIO& platform_io = ImGui::GetPlatformIO();
ImGui_ImplVulkan_CreateWindow = platform_io.Renderer_CreateWindow;
Expand Down Expand Up @@ -442,16 +432,6 @@ bool VulkanWindow::UpdateFramebuffer()
return true;
}

float VulkanWindow::GetContentScale()
{
float xscale;
float yscale;
glfwGetWindowContentScale(m_window, &xscale, &yscale);

// Hope this works well should a screen have unequal X- and Y- DPIs...
return (xscale + yscale) / 2;
}

void VulkanWindow::Render()
{
if(m_softwareResizeRequested)
Expand Down
Loading