Fix imgui not building on distros which don't have wayland headers on the default include path on Linux#904
Merged
azonenberg merged 1 commit intongscopeclient:masterfrom Sep 27, 2025
Conversation
… the default include path on Linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 4457dd5 updated imgui to a version which pulls in GLFW's wayland implementation in a mandatory way, which requires wayland-client headers.
This builds fine on most distros, however some like openSUSE Tumbleweed (and presumably Leap too, haven't checked) have
wayland-client.hin a subdirectory, not in the main include path, which usally is/usr/include.See output of RPM to show the directory structure on Tumbleweed:
This change builds fine on all Linux distros in CI, wayland-client libraries are pulled in implicitly already, but if needed I can update the docs to include installation of this library