Instrument manager rework#951
Merged
azonenberg merged 17 commits intongscopeclient:masterfrom Jan 26, 2026
Merged
Conversation
…n of a given nickname when duplicated. When reconnection fails for a recent instrument, respawn a AddInstrumentDialog to allow modifying the connetion parameters.
…ror dialog. Moved PreloadConfiguration before AddInstrument() for Mockable instruments to allow channel creation before instrument state is initialized. Only create InstrumentThread if Instrument is online.
Added String support for EditableProperties. Added rename (change nickname) support to ManageInstrument dialog + update nickname in recent instrument list. Removed (unused) selection on instrument list.
Fixed intrument list change in ManageInstrumentDialog.
Collaborator
|
@fredzo I'm seeing build issues with this, looks like you might not be synced with all of my recent updates. Let me know when it's ready to merge. |
Contributor
Author
Yes, I just finished merging, I'll hit you when build is OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
This is the second part of my work on ManageInstrumentDialog and Mock instruments (goes with ngscopeclient/scopehal#1057).
It also fixes Digital Bank handling when there is only one digital channel in the bank.
Changes are:
Change path after failed connection:
Rename instruments:
Edit path on offline instruments:
