Skip to content

WaveformArea/WaveformGroup Drang And Drop fixes#972

Merged
azonenberg merged 9 commits intongscopeclient:masterfrom
fredzo:waveform-area-dnd-fixes
Mar 20, 2026
Merged

WaveformArea/WaveformGroup Drang And Drop fixes#972
azonenberg merged 9 commits intongscopeclient:masterfrom
fredzo:waveform-area-dnd-fixes

Conversation

@fredzo
Copy link
Copy Markdown
Contributor

@fredzo fredzo commented Feb 15, 2026

Hi Andrew,

This PR is a rework of the way drag and drop is handled in WaveformArea and WaveformGroup.
It fixes #642, #636 and #833.
What's been done:

  • Added a new "insertion line" visual feedback when dragging an stream in a waveform area to show where to insert the stream in the channel list.
  • A stream can now be moved within the same waveform area to change it's position in the channel list.
  • Added a visual feedback (not_allowed cursor) when trying to add a stream that is already present in a waveform area.
  • Replaced original CenterLeftDropArea() with a zone that covers all the waveform area with the insertion point line feedback.
  • Reduced the size of EdgeDropArea to 10% of the area to ease the use of the center drop when the waveform area is small.
  • CenterRightDropArea (used for split) is now available at the top of each waveform area and at the bottom of the last, allowing the user to choose at which point the new waveform area has to be created.
  • CenterRightDropArea height is dynamically reduced to accommodate waveform area with small heigth
  • Edge and Split drop areas have priority over Center drop area.

ngscopeclient_nJcq1bRp0a

Frederic Borry and others added 9 commits February 13, 2026 08:37
@azonenberg azonenberg merged commit 418d2bc into ngscopeclient:master Mar 20, 2026
23 checks passed
@fredzo fredzo deleted the waveform-area-dnd-fixes branch March 20, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow drag and drop reordering of channels within a WaveformArea

2 participants