Filtering classes by annotation#2
Open
nhachicha wants to merge 2 commits into
Open
Conversation
Owner
Author
|
@rorbech FYI |
rorbech
reviewed
Sep 8, 2020
rorbech
left a comment
rorbech
left a comment
Contributor
There was a problem hiding this comment.
Concept seems sound, but should probably be self contained in the sample project, either by declaring the annotation as part of an annotation dependency or accepting the annotation class name as a plugin parameter.
| // Annotation | ||
| private val IrClass.isRealmObject: Boolean get() = kind == ClassKind.CLASS && hasRealmObjectAnnotationWithoutArgs() | ||
|
|
||
| private val realmObjectAnnotationFqName = FqName("io.realm.kmmapplication.shared.RealmObject") |
Contributor
There was a problem hiding this comment.
I guess we should expose the annotation as part of the plugin.
Contributor
There was a problem hiding this comment.
I think you would inject these kind of dependencies by adding them to the project by overriding the apply(target: Project) in the gradle plugins implementation of KotlinCompilerPluginSupportPlugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter
IrClassto be lowered to those having a specific annotationAdding logger using the Ir
dumphelper function