Fix math functions for percent#329
Open
StefanoD wants to merge 2 commits into
Open
Conversation
Owner
|
I think this may stem from a misunderstanding of how concentrations are intended to work. The following tests will pass in the library as it currently exists: percent resultPct = sqrt(16.0_pct); So the idea is that 4% when it's a dimensionless absolute value is 0.04. |
|
Shouldn't |
Author
|
If you go to my linked ticket, I showed different calculations which failed. This is IMHO a regression which previously worked in an older version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328
Note: I tried to alter all math functions, but this resulted in some unit tests failing. There might be some rework needed from somebody with more knowledge.