Skip to content

Commit 2b7f5fa

Browse files
committed
lint
Change-Id: I3424c7df7226f4a27051050598792ee7836379df
1 parent 1407bec commit 2b7f5fa

2 files changed

Lines changed: 8 additions & 13 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,7 @@ public static BigtableChannelPool create(
9494
ImmutableList.Builder<Entry> initialListBuilder = ImmutableList.builder();
9595

9696
for (int i = 0; i < settings.getInitialChannelCount(); i++) {
97-
initialListBuilder.add(
98-
new Entry(channelFactory.createSingleChannel()));
97+
initialListBuilder.add(new Entry(channelFactory.createSingleChannel()));
9998
}
10099

101100
entries.set(initialListBuilder.build());
@@ -319,8 +318,7 @@ private void expand(int desiredSize) {
319318

320319
for (int i = 0; i < desiredSize - localEntries.size(); i++) {
321320
try {
322-
newEntries.add(
323-
new Entry(channelFactory.createSingleChannel()));
321+
newEntries.add(new Entry(channelFactory.createSingleChannel()));
324322
} catch (IOException e) {
325323
LOG.log(Level.WARNING, "Failed to add channel", e);
326324
}
@@ -358,8 +356,7 @@ void refresh() {
358356

359357
for (int i = 0; i < newEntries.size(); i++) {
360358
try {
361-
newEntries.set(
362-
i, new Entry(channelFactory.createSingleChannel()));
359+
newEntries.set(i, new Entry(channelFactory.createSingleChannel()));
363360
} catch (IOException e) {
364361
LOG.log(Level.WARNING, "Failed to refresh channel, leaving old channel", e);
365362
}

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/ChannelPoolHealthChecker.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,13 @@ public void stop() {
7070
/** Runs probes on all the channels in the pool. (No-op stub) */
7171
private void runProbes() {
7272
// Method stub, no operation.
73-
for (Entry entry: this.entrySupplier.get()) {
74-
//pingAndWarm
73+
for (Entry entry : this.entrySupplier.get()) {
74+
// pingAndWarm
7575
}
7676
}
7777

7878
/** Callback that will update Entry data on probe complete. (No-op stub) */
79-
private void onComplete() {
80-
81-
}
79+
private void onComplete() {}
8280

8381
/**
8482
* Finds a channel that is an outlier in terms of health. (No-op stub)
@@ -93,8 +91,8 @@ private Entry findOutlierEntry() {
9391
/** Periodically detects and removes outlier channels from the pool. (No-op stub) */
9492
private void detectAndRemoveOutlierEntries() {
9593
// Method stub, no operation.
96-
for (Entry entry: this.entrySupplier.get()) {
97-
//if not healthy, enterIdle
94+
for (Entry entry : this.entrySupplier.get()) {
95+
// if not healthy, enterIdle
9896
}
9997
}
10098
}

0 commit comments

Comments
 (0)