Skip to content

Commit e8288b0

Browse files
committed
fixes
Change-Id: Ibaa32ee3425b23596a3141bb4e29cfb068caf0ee
1 parent 39f3077 commit e8288b0

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/NoOpChannelPrimer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,11 @@
1515
*/
1616
package com.google.cloud.bigtable.data.v2.stub;
1717

18+
import com.google.api.core.InternalApi;
1819
import com.google.api.gax.grpc.ChannelPrimer;
1920
import io.grpc.ManagedChannel;
2021

22+
@InternalApi
2123
public class NoOpChannelPrimer implements ChannelPrimer {
2224
static NoOpChannelPrimer create() {
2325
return new NoOpChannelPrimer();

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,7 @@ public static BigtableChannelPool create(
101101

102102
for (int i = 0; i < settings.getInitialChannelCount(); i++) {
103103
ManagedChannel newChannel = channelFactory.createSingleChannel();
104-
if (channelPrimer != null) {
105-
channelPrimer.primeChannel(newChannel);
106-
}
104+
channelPrimer.primeChannel(newChannel);
107105
initialListBuilder.add(new Entry(newChannel));
108106
}
109107

@@ -329,9 +327,7 @@ private void expand(int desiredSize) {
329327
for (int i = 0; i < desiredSize - localEntries.size(); i++) {
330328
try {
331329
ManagedChannel newChannel = channelFactory.createSingleChannel();
332-
if (this.channelPrimer != null) {
333-
this.channelPrimer.primeChannel(newChannel);
334-
}
330+
this.channelPrimer.primeChannel(newChannel);
335331
newEntries.add(new Entry(newChannel));
336332
} catch (IOException e) {
337333
LOG.log(Level.WARNING, "Failed to add channel", e);
@@ -371,9 +367,7 @@ void refresh() {
371367
for (int i = 0; i < newEntries.size(); i++) {
372368
try {
373369
ManagedChannel newChannel = channelFactory.createSingleChannel();
374-
if (this.channelPrimer != null) {
375-
this.channelPrimer.primeChannel(newChannel);
376-
}
370+
this.channelPrimer.primeChannel(newChannel);
377371
newEntries.set(i, new Entry(newChannel));
378372
} catch (IOException e) {
379373
LOG.log(Level.WARNING, "Failed to refresh channel, leaving old channel", e);

0 commit comments

Comments
 (0)