fix: portal positioning, table hover/scroll, tree right-click, cursor in nested containers

- PortalPositioner: shift portal up before truncating when near bottom edge
- TableControl: fix last row invisible when filtering enabled without border
- TableControl: clear hover on scroll offset change, data reset, and ClearRows
- TreeControl: add LastRightClickedNode property for right-click without selection change
- TreeControl: add HoverEnabled property to disable hover highlighting
- ColumnContainer: implement ILogicalCursorProvider to propagate cursor position
- HorizontalGridControl: add column offset to cursor position translation
- ScrollablePanelControl: implement ILogicalCursorProvider with scroll offset

Author: nickprotop

SharpConsoleUI/Controls/ColumnContainer.cs

@@ -21,7 +21,7 @@ namespace SharpConsoleUI.Controls
 	/// A container control that holds child controls vertically within a column of a <see cref="HorizontalGridControl"/>.
 	/// Supports layout constraints, focus management, and dynamic content sizing.
 	/// </summary>
-	public class ColumnContainer : IContainer, IInteractiveControl, IFocusableControl, IMouseAwareControl, ILayoutAware, IDOMPaintable, IContainerControl
+	public class ColumnContainer : IContainer, IInteractiveControl, IFocusableControl, IMouseAwareControl, ILayoutAware, IDOMPaintable, IContainerControl, ILogicalCursorProvider
 	{
 		private HorizontalAlignment _horizontalAlignment = HorizontalAlignment.Left;
 		private VerticalAlignment _verticalAlignment = VerticalAlignment.Fill;
@@ -651,6 +651,24 @@ public bool ProcessKey(ConsoleKeyInfo key)
 		/// </summary>
 		public bool CanReceiveFocus => false;
 
+		/// <inheritdoc/>
+		public System.Drawing.Point? GetLogicalCursorPosition()
+		{
+			var focusManager = (this as IWindowControl).GetParentWindow()?.FocusManager;
+			var focused = GetInteractiveContents()
+				.FirstOrDefault(c => c is IFocusableControl fc && (focusManager?.IsFocused(fc) ?? false));
+			return (focused as ILogicalCursorProvider)?.GetLogicalCursorPosition();
+		}
+
+		/// <inheritdoc/>
+		public void SetLogicalCursorPosition(System.Drawing.Point position)
+		{
+			var focusManager = (this as IWindowControl).GetParentWindow()?.FocusManager;
+			var focused = GetInteractiveContents()
+				.FirstOrDefault(c => c is IFocusableControl fc && (focusManager?.IsFocused(fc) ?? false));
+			(focused as ILogicalCursorProvider)?.SetLogicalCursorPosition(position);
+		}
+
 		/// <inheritdoc/>
 		public System.Drawing.Size GetLogicalContentSize()
 		{

SharpConsoleUI/Controls/HorizontalGridControl/HorizontalGridControl.Layout.cs

@@ -86,8 +86,18 @@ public IReadOnlyList<IWindowControl> GetChildren()
 
 				if (childPosition.HasValue && focusedContent is IWindowControl focusedControl)
 				{
-					// For now, just return child position as-is
-					// The proper offset will be accumulated in TranslateLogicalCursorToWindow
+					// Find the column containing the focused control and add its offset
+					List<ColumnContainer> columns;
+					lock (_gridLock) { columns = new List<ColumnContainer>(_columns); }
+					foreach (var col in columns)
+					{
+						if (col.Contents.Contains(focusedControl))
+						{
+							int offsetX = col.ActualX - ActualX;
+							int offsetY = col.ActualY - ActualY;
+							return new Point(childPosition.Value.X + offsetX, childPosition.Value.Y + offsetY);
+						}
+					}
 				}
 
 				return childPosition;

SharpConsoleUI/Controls/ScrollablePanelControl/ScrollablePanelControl.cs

@@ -18,7 +18,7 @@ namespace SharpConsoleUI.Controls
 	/// A scrollable panel control that can host child controls with automatic scrolling support.
 	/// Supports vertical and horizontal scrolling, mouse wheel, and visual scrollbars.
 	/// </summary>
-	public partial class ScrollablePanelControl : BaseControl, IInteractiveControl, IFocusableControl, IMouseAwareControl, IContainer, IContainerControl, IScrollableContainer, IFocusScope
+	public partial class ScrollablePanelControl : BaseControl, IInteractiveControl, IFocusableControl, IMouseAwareControl, IContainer, IContainerControl, IScrollableContainer, IFocusScope, ILogicalCursorProvider
 	{
 		private readonly List<IWindowControl> _children = new();
 		private readonly object _childrenLock = new();
@@ -405,6 +405,36 @@ public bool IsEnabled
 			return null;
 		}
 
+		/// <inheritdoc/>
+		public System.Drawing.Point? GetLogicalCursorPosition()
+		{
+			var focused = GetFocusedChildFromCoordinator();
+			if (focused is ILogicalCursorProvider cursorProvider)
+			{
+				var childPos = cursorProvider.GetLogicalCursorPosition();
+				if (childPos.HasValue && focused is IWindowControl wc)
+				{
+					return new System.Drawing.Point(
+						childPos.Value.X + wc.ActualX - ActualX,
+						childPos.Value.Y + wc.ActualY - ActualY - _verticalScrollOffset);
+				}
+			}
+			return null;
+		}
+
+		/// <inheritdoc/>
+		public void SetLogicalCursorPosition(System.Drawing.Point position)
+		{
+			var focused = GetFocusedChildFromCoordinator();
+			if (focused is ILogicalCursorProvider cursorProvider && focused is IWindowControl wc)
+			{
+				var childPos = new System.Drawing.Point(
+					position.X - wc.ActualX + ActualX,
+					position.Y - wc.ActualY + ActualY + _verticalScrollOffset);
+				cursorProvider.SetLogicalCursorPosition(childPos);
+			}
+		}
+
 		#endregion
 
 		#region IContainer Implementation

SharpConsoleUI/Controls/TableControl/TableControl.Scrolling.cs

@@ -24,9 +24,14 @@ public int ScrollOffset
 		set
 		{
 			int maxOffset = Math.Max(0, RowCount - GetVisibleRowCount());
-			_scrollOffset = Math.Clamp(value, 0, maxOffset);
-			OnPropertyChanged();
-			Container?.Invalidate(true);
+			int clamped = Math.Clamp(value, 0, maxOffset);
+			if (clamped != _scrollOffset)
+			{
+				_scrollOffset = clamped;
+				_hoveredRowIndex = -1;
+				OnPropertyChanged();
+				Container?.Invalidate(true);
+			}
 		}
 	}
 
@@ -104,8 +109,8 @@ private int CalculateVisibleRowsFromHeight(int totalHeight)
 		if (ShouldShowHorizontalScrollbar())
 			usedHeight++;
 
-		// Reserve space for filter status bar (separator + status row)
-		if (_filteringEnabled && !_readOnly)
+		// Reserve space for filter status bar (separator + status row) — only rendered with borders
+		if (_filteringEnabled && !_readOnly && hasBorder)
 			usedHeight += 2;
 
 		int availableLines = Math.Max(0, totalHeight - usedHeight);
@@ -125,6 +130,7 @@ internal void EnsureSelectedRowVisible()
 		if (_selectedRowIndex < 0) return;
 
 		int visibleRows = GetVisibleRowCount();
+		int oldOffset = _scrollOffset;
 
 		if (_selectedRowIndex < _scrollOffset)
 		{
@@ -135,6 +141,9 @@ internal void EnsureSelectedRowVisible()
 			_scrollOffset = _selectedRowIndex - visibleRows + 1;
 		}
 
+		if (_scrollOffset != oldOffset)
+			_hoveredRowIndex = -1;
+
 		// Clamp
 		int maxOffset = Math.Max(0, RowCount - visibleRows);
 		_scrollOffset = Math.Clamp(_scrollOffset, 0, maxOffset);

SharpConsoleUI/Controls/TableControl/TableControl.cs

@@ -383,6 +383,7 @@ public ITableDataSource? DataSource
 			_measurementCache.InvalidateCache();
 			_selectedRowIndex = -1;
 			_selectedColumnIndex = -1;
+			_hoveredRowIndex = -1;
 			_scrollOffset = 0;
 			_horizontalScrollOffset = 0;
 			_sortColumnIndex = -1;
@@ -402,6 +403,7 @@ private void OnDataSourceCollectionChanged(object? sender, NotifyCollectionChang
 		{
 			_selectedRowIndex = RowCount > 0 ? 0 : -1;
 			_selectedRowIndices.Clear();
+			_hoveredRowIndex = -1;
 			_scrollOffset = 0;
 		}
 		InvalidateColumnWidths();
@@ -725,6 +727,7 @@ public void ClearRows()
 		lock (_tableLock) { _rows.Clear(); }
 		_selectedRowIndex = -1;
 		_selectedColumnIndex = -1;
+		_hoveredRowIndex = -1;
 		_scrollOffset = 0;
 		_horizontalScrollOffset = 0;
 		_selectedRowIndices.Clear();

SharpConsoleUI/Controls/TreeControl/TreeControl.Mouse.cs

@@ -153,15 +153,18 @@ public bool ProcessMouseEvent(MouseEventArgs args)
 				bool mouseOnScrollbar = IsClickOnScrollbar(args.Position.X, sbContentWidth);
 
 				// Update hover state (only when mouse is over content, not scrollbar)
-				if (!mouseOnScrollbar && nodeIndex != _hoveredIndex)
+				if (_hoverEnabled)
 				{
-					_hoveredIndex = nodeIndex;
-					Container?.Invalidate(true);
-				}
-				else if (mouseOnScrollbar && _hoveredIndex != -1)
-				{
-					_hoveredIndex = -1;
-					Container?.Invalidate(true);
+					if (!mouseOnScrollbar && nodeIndex != _hoveredIndex)
+					{
+						_hoveredIndex = nodeIndex;
+						Container?.Invalidate(true);
+					}
+					else if (mouseOnScrollbar && _hoveredIndex != -1)
+					{
+						_hoveredIndex = -1;
+						Container?.Invalidate(true);
+					}
 				}
 
 				// Handle mouse wheel scrolling
@@ -199,10 +202,18 @@ public bool ProcessMouseEvent(MouseEventArgs args)
 				// Handle right-click
 				if (args.HasFlag(MouseFlags.Button3Clicked))
 				{
-					if (!mouseOnScrollbar && _selectOnRightClick && nodeIndex >= 0 && nodeIndex < _flattenedNodes.Count)
+					if (!mouseOnScrollbar && nodeIndex >= 0 && nodeIndex < _flattenedNodes.Count)
 					{
-						SelectNodeNoScroll(nodeIndex);
-						Container?.Invalidate(true);
+						_lastRightClickedNode = _flattenedNodes[nodeIndex];
+						if (_selectOnRightClick)
+						{
+							SelectNodeNoScroll(nodeIndex);
+							Container?.Invalidate(true);
+						}
+					}
+					else
+					{
+						_lastRightClickedNode = null;
 					}
 					fireMouseRightClick = args;
 					result = true;

SharpConsoleUI/Controls/TreeControl/TreeControl.cs

@@ -50,7 +50,9 @@ public partial class TreeControl : BaseControl, IInteractiveControl, IFocusableC
 
 		// Mouse interaction state
 		private int _hoveredIndex = -1;
+		private bool _hoverEnabled = true;
 		private bool _selectOnRightClick = false;
+		private TreeNode? _lastRightClickedNode;
 		private readonly object _clickLock = new object();
 		private DateTime _lastClickTime = DateTime.MinValue;
 		private int _lastClickIndex = -1;
@@ -208,6 +210,21 @@ public bool SelectOnRightClick
 			set { _selectOnRightClick = value; OnPropertyChanged(); }
 		}
 
+		/// <summary>
+		/// Gets or sets whether mouse hover highlighting is enabled. Default: true.
+		/// </summary>
+		public bool HoverEnabled
+		{
+			get => _hoverEnabled;
+			set { _hoverEnabled = value; if (!value) _hoveredIndex = -1; OnPropertyChanged(); Container?.Invalidate(true); }
+		}
+
+		/// <summary>
+		/// Gets the node that was under the cursor during the most recent right-click.
+		/// Set before <see cref="MouseRightClick"/> fires, regardless of <see cref="SelectOnRightClick"/>.
+		/// </summary>
+		public TreeNode? LastRightClickedNode => _lastRightClickedNode;
+
 		/// <inheritdoc/>
 		public ScrollbarVisibility ScrollbarVisibility
 		{

SharpConsoleUI/Layout/PortalPositioner.cs

@@ -135,19 +135,22 @@ public static PortalPositionResult Calculate(PortalPositionRequest request)
 				wasClamped = true;
 			}
 
-			// Clamp vertical
+			// Clamp vertical — shift before truncating so the portal stays fully visible when possible
 			if (y + height > screen.Bottom)
 			{
-				height = screen.Bottom - y;
+				int shift = y + height - screen.Bottom;
+				y -= shift;
 				wasClamped = true;
 			}
 			if (y < screen.Y)
 			{
-				int overflow = screen.Y - y;
-				height -= overflow;
 				y = screen.Y;
 				wasClamped = true;
 			}
+			if (y + height > screen.Bottom)
+			{
+				height = screen.Bottom - y;
+			}
 
 			// Ensure non-negative dimensions
 			width = Math.Max(0, width);
@@ -175,7 +178,7 @@ public static PortalPositionResult CalculateFromPoint(
 			PortalPlacement placement = PortalPlacement.BelowOrAbove,
 			Size minSize = default)
 		{
-			// Point anchor → zero-width, 1-height rect (cursor occupies 1 row)
+			// Point anchor → 1-height rect (cursor occupies 1 row, portal opens below/above it)
 			var anchorRect = new Rectangle(anchor.X, anchor.Y, 0, 1);
 			var result = Calculate(new PortalPositionRequest(anchorRect, contentSize, screenBounds, placement));