Skip to content

Commit 2e51d91

Browse files
committed
Fix CloudSyncValidator tests to expect errors for DefaultLanguage mismatch
1 parent 039549a commit 2e51d91

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

LocalizationManager.Tests/UnitTests/Cloud/CloudSyncValidatorTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public void ValidateForPush_ResxToJson_CannotSync()
7474
}
7575

7676
[Fact]
77-
public void ValidateForPush_DifferentDefaultLanguage_ReturnsWarning()
77+
public void ValidateForPush_DifferentDefaultLanguage_ReturnsError()
7878
{
7979
// Arrange
8080
var localConfig = new ConfigurationModel { ResourceFormat = "resx", DefaultLanguageCode = "en" };
@@ -85,8 +85,8 @@ public void ValidateForPush_DifferentDefaultLanguage_ReturnsWarning()
8585
var result = _validator.ValidateForPush(localConfig, remoteProject);
8686

8787
// Assert
88-
Assert.True(result.CanSync); // Warning doesn't block
89-
Assert.Contains(result.Warnings, w => w.Contains("Default language mismatch"));
88+
Assert.False(result.CanSync); // DefaultLanguage mismatch blocks sync - would corrupt data
89+
Assert.Contains(result.Errors, e => e.Contains("Default language mismatch"));
9090
}
9191

9292
[Fact]
@@ -216,7 +216,7 @@ public void ValidateForPull_FormatMismatch_CannotSync()
216216
}
217217

218218
[Fact]
219-
public void ValidateForPull_DifferentDefaultLanguage_ReturnsWarningButCanSync()
219+
public void ValidateForPull_DifferentDefaultLanguage_ReturnsErrorAndCannotSync()
220220
{
221221
// Arrange
222222
var localConfig = new ConfigurationModel { ResourceFormat = "resx", DefaultLanguageCode = "en" };
@@ -226,8 +226,8 @@ public void ValidateForPull_DifferentDefaultLanguage_ReturnsWarningButCanSync()
226226
var result = _validator.ValidateForPull(localConfig, remoteProject);
227227

228228
// Assert
229-
Assert.True(result.CanSync);
230-
Assert.Contains(result.Warnings, w => w.Contains("Default language mismatch"));
229+
Assert.False(result.CanSync); // DefaultLanguage mismatch blocks sync - would corrupt data
230+
Assert.Contains(result.Errors, e => e.Contains("Default language mismatch"));
231231
}
232232

233233
#endregion

0 commit comments

Comments
 (0)