Fix plural translation for unsaved UI changes

- Add KeyTranslationMetadata to TranslateRequestDto for explicit key state
- API uses KeyMetadata.IsPlural instead of inferring from string patterns
- Editor passes KeyMetadata to TranslateDialog for both bulk and single key translate
- KeyDetailDrawer creates cells for all languages when converting to plural

Author: nickprotop

cloud/src/LrmCloud.Api/Services/Translation/CloudTranslationService.cs

@@ -153,8 +153,14 @@ public async Task<TranslateResponseDto> TranslateKeysAsync(
             // Process each key and target language
             foreach (var key in keys)
             {
+                // Determine if key is plural: use KeyMetadata from client if provided (for unsaved UI changes),
+                // otherwise fall back to database value
+                var isPlural = request.KeyMetadata?.TryGetValue(key.KeyName, out var metadata) == true
+                    ? metadata.IsPlural
+                    : key.IsPlural;
+
                 // Get plural forms to process (empty string for non-plural keys)
-                var pluralForms = key.IsPlural
+                var pluralForms = isPlural
                     ? new[] { "one", "other", "zero", "two", "few", "many" }
                     : new[] { "" };
 

cloud/src/LrmCloud.Shared/DTOs/Translation/TranslateRequestDto.cs

@@ -62,6 +62,26 @@ public class TranslateRequestDto
     /// Defaults to true for CLI compatibility.
     /// </summary>
     public bool SaveToDatabase { get; set; } = true;
+
+    /// <summary>
+    /// Optional metadata about keys being translated. When provided, overrides
+    /// database values for key properties like IsPlural. This allows translating
+    /// keys with unsaved UI changes.
+    /// Key = resource key name, Value = metadata.
+    /// </summary>
+    public Dictionary<string, KeyTranslationMetadata>? KeyMetadata { get; set; }
+}
+
+/// <summary>
+/// Metadata about a key being translated.
+/// </summary>
+public class KeyTranslationMetadata
+{
+    /// <summary>
+    /// Whether this key is plural. When true, translates all plural forms.
+    /// Overrides the database value when provided.
+    /// </summary>
+    public bool IsPlural { get; set; }
 }
 
 /// <summary>

cloud/src/LrmCloud.Web/Components/KeyDetailDrawer.razor

@@ -422,13 +422,14 @@
             // Initialize active forms
             _activePluralForms = new HashSet<string> { PluralForms.One, PluralForms.Other };
 
-            // Create empty "one" forms
+            // Create empty cells for both "one" and "other" forms for ALL languages
             foreach (var lang in Languages)
             {
-                var key = TranslationGridRow.GetKey(lang, PluralForms.One);
-                if (!Row.Translations.ContainsKey(key))
+                // Create "one" form if missing
+                var oneKey = TranslationGridRow.GetKey(lang, PluralForms.One);
+                if (!Row.Translations.ContainsKey(oneKey))
                 {
-                    Row.Translations[key] = new TranslationCell
+                    Row.Translations[oneKey] = new TranslationCell
                     {
                         LanguageCode = lang,
                         PluralForm = PluralForms.One,
@@ -437,6 +438,20 @@
                         IsDirty = true
                     };
                 }
+
+                // Create "other" form if missing (for languages that had no translation)
+                var otherKey = TranslationGridRow.GetKey(lang, PluralForms.Other);
+                if (!Row.Translations.ContainsKey(otherKey))
+                {
+                    Row.Translations[otherKey] = new TranslationCell
+                    {
+                        LanguageCode = lang,
+                        PluralForm = PluralForms.Other,
+                        Value = null,
+                        OriginalValue = null,
+                        IsDirty = true
+                    };
+                }
             }
         }
         else

cloud/src/LrmCloud.Web/Components/TranslateDialog.razor

@@ -184,6 +184,13 @@
     [Parameter]
     public Dictionary<string, string>? SourceTexts { get; set; }
 
+    /// <summary>
+    /// Optional metadata about keys being translated. When provided, overrides database values
+    /// for key properties like IsPlural. This allows translating keys with unsaved UI changes.
+    /// </summary>
+    [Parameter]
+    public Dictionary<string, KeyTranslationMetadata>? KeyMetadata { get; set; }
+
     private List<TranslationProviderDto> _providers = new();
     private string? _selectedProvider;
     private HashSet<string> _selectedLanguages = new();
@@ -304,7 +311,8 @@
                 Overwrite = _overwrite,
                 Context = _context,
                 SaveToDatabase = false,  // Return translations for UI preview, don't save yet
-                SourceTexts = SourceTexts  // Pass current UI values if provided
+                SourceTexts = SourceTexts,  // Pass current UI values if provided
+                KeyMetadata = KeyMetadata   // Pass key metadata (e.g., IsPlural) for unsaved UI changes
             };
 
             _translationResult = await TranslationService.TranslateKeysAsync(ProjectId, request);

cloud/src/LrmCloud.Web/Pages/Projects/Editor.razor

@@ -563,13 +563,17 @@ else
         // Build source texts from current UI state (may include unsaved edits)
         var sourceTexts = BuildSourceTextsFromRows(rowList, _project.DefaultLanguage);
 
+        // Build key metadata to tell API about unsaved state (e.g., IsPlural)
+        var keyMetadata = BuildKeyMetadataFromRows(rowList);
+
         var parameters = new DialogParameters
         {
             { nameof(TranslateDialog.ProjectId), ProjectId },
             { nameof(TranslateDialog.SourceLanguage), _project.DefaultLanguage },
             { nameof(TranslateDialog.AvailableLanguages), _languages },
             { nameof(TranslateDialog.KeysToTranslate), rowList.Select(r => r.KeyName).ToList() },
-            { nameof(TranslateDialog.SourceTexts), sourceTexts }
+            { nameof(TranslateDialog.SourceTexts), sourceTexts },
+            { nameof(TranslateDialog.KeyMetadata), keyMetadata }
         };
 
         var options = new DialogOptions
@@ -711,16 +715,22 @@ else
     {
         if (_project == null) return;
 
+        var rowList = new List<TranslationGridRow> { row };
+
         // Build source texts from current UI state (may include unsaved edits)
-        var sourceTexts = BuildSourceTextsFromRows(new List<TranslationGridRow> { row }, _project.DefaultLanguage);
+        var sourceTexts = BuildSourceTextsFromRows(rowList, _project.DefaultLanguage);
+
+        // Build key metadata to tell API about unsaved state (e.g., IsPlural)
+        var keyMetadata = BuildKeyMetadataFromRows(rowList);
 
         var parameters = new DialogParameters
         {
             { nameof(TranslateDialog.ProjectId), ProjectId },
             { nameof(TranslateDialog.SourceLanguage), _project.DefaultLanguage },
             { nameof(TranslateDialog.AvailableLanguages), _languages },
             { nameof(TranslateDialog.KeysToTranslate), new List<string> { row.KeyName } },
-            { nameof(TranslateDialog.SourceTexts), sourceTexts }
+            { nameof(TranslateDialog.SourceTexts), sourceTexts },
+            { nameof(TranslateDialog.KeyMetadata), keyMetadata }
         };
 
         var options = new DialogOptions
@@ -738,7 +748,7 @@ else
         {
             // Apply translations to the drawer row only (cells will update in place)
             // User must click "Apply" to stage changes, then "Save" to persist
-            ApplyTranslationsToDrawerRow(row, translationResult);
+            await ApplyTranslationsToDrawerRow(row, translationResult);
         }
     }
 
@@ -747,7 +757,7 @@ else
     /// Unlike ApplyTranslationsToUI, this does NOT stage to _editedRows - the user must click Apply.
     /// Handles both non-plural and plural keys.
     /// </summary>
-    private void ApplyTranslationsToDrawerRow(TranslationGridRow row, TranslateResponseDto translationResult)
+    private async Task ApplyTranslationsToDrawerRow(TranslationGridRow row, TranslateResponseDto translationResult)
     {
         var appliedCount = 0;
 
@@ -779,10 +789,10 @@ else
 
         if (appliedCount > 0)
         {
-            // Refresh the drawer's plural form display to show new cells
-            _keyDetailDrawer?.RefreshActivePluralForms();
             Snackbar.Add($"Applied {appliedCount} translations. Click Apply to stage changes.", Severity.Success);
+            // First update parent state, then refresh drawer to show new cells/values
             StateHasChanged();
+            await InvokeAsync(() => _keyDetailDrawer?.RefreshActivePluralForms());
         }
     }
 
@@ -824,6 +834,25 @@ else
         return sourceTexts;
     }
 
+    /// <summary>
+    /// Builds a dictionary of key metadata from the current UI state.
+    /// This tells the API about unsaved changes like IsPlural conversions.
+    /// </summary>
+    private Dictionary<string, KeyTranslationMetadata> BuildKeyMetadataFromRows(List<TranslationGridRow> rows)
+    {
+        var metadata = new Dictionary<string, KeyTranslationMetadata>();
+
+        foreach (var row in rows)
+        {
+            metadata[row.KeyName] = new KeyTranslationMetadata
+            {
+                IsPlural = row.IsPlural
+            };
+        }
+
+        return metadata;
+    }
+
     private async Task DeleteKey(TranslationGridRow row)
     {
         _pendingDeleteRows = new[] { row };