Adding VeryHigh Overview Display Option

[vanmegen]

This is analog to the nightscout Very High setting which displays bg values higher than a configurable value in a different color.
I did set the default to 400, but it can be set to 240 to be a similar threshold as nightscout uses.

(in the following screenshot red dots mark values higher than 220)

I have added this to the overview settings

And added this to the startup-wizzard

Widgets are updated as well

And watchfaces

[vanmegen]

Note, this is an updated version of PR #3678

[vanmegen]

@olorinmaia, @Philoul @koelewij
Please consider this PR to continue our discussions

[koelewij]

To my opinion this is a change with minimal impact. If users don't want the extra range, they can set the limits to such a value that they still have the old behavior.
On the high range just set the red limit to max.
For the lower side just set both the same, so there is only red and no yellow.

[vanmegen]

@koelewij Thank you very much for your comment!

@olorinmaia , @Philoul @koelewij Sorry to ping again. I am just wondering that you are ok with this PR (as you helped with/commented) the original PR #3678 already.

kind regards,
friedel

[Philoul]

@vanmegen
Sorry, I didn't had time to test your PR until now.

• Reading comments and screenshots, a lot of work has been done to have the same BG colors everywhere, including into wizard and watch 👍

I will try to find time to test it to provide you my comments, but not sure very quickly 🥵...

[vanmegen]

Hi @Philoul,
thank you very much for your kind comments.

I just realized that I forgot to put screenshots for some additional places where the new UI displays blood sugar values

Insulin

Carbs

and the combination carbs/insulin dialog

kind regards,
friedel

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Philoul]

I tested it on my dev phone, here are my different comments:
Concerning very low:

1. default value and minimum value should be set to 39 mg/dl (or 25 ???).

• AAPS don't manage values lower than 39 and I was surprised to see 25 as minimum in current OverviewLowMark double key, and 72 for default and not 70... (@MilosKozak an error or is it intended?)
• Default value for VeryLow should be aligned to the minimum value to not change default colors (by default very low override low if the very low value is above low value)

2. I think within User Interface Maximum value for VeryLow should be equal to the selected Low Value (and hardcoded within OverviewVeryLowMark (maxMgdl) to 72 (or 70) and not 160 mg/dl

• The user should not be able to select an higher value for very low compared to low, and same constraint for Very High that should always be above or equal high value

Concerning the Very High maximum and default value, it should be the maximum allowed value (I don't remember if it's 380 or 400 mgdl...)

By default, if this feature is included, it should be "transparent" for users: they will have enough new things just with the new UI, so I don't think we should add something additional visible. Then those who will want to adjust settings to see very high and Very Low will be able to adjust settings accordingly.