Batch: Allow using IAM instance profile name when creating compute env

Author: nik-localstack

moto/batch/models.py

@@ -1344,7 +1344,7 @@ def _validate_compute_resources(self, cr: Dict[str, Any]) -> None:
                     "Error executing request, Exception : Instance role is required."
                 )
             for profile in self.iam_backend.get_instance_profiles():
-                if profile.arn == cr["instanceRole"]:
+                if profile.arn == cr["instanceRole"] or profile.name == cr["instanceRole"]:
                     break
             else:
                 raise InvalidParameterValueException(

tests/test_batch/test_batch_compute_envs.py

@@ -9,10 +9,12 @@
 
 
 @mock_aws
-def test_create_managed_compute_environment():
+@pytest.mark.parametrize('use_arn_for_instance_role', [True, False])
+def test_create_managed_compute_environment(use_arn_for_instance_role):
     ec2_client, iam_client, ecs_client, _, batch_client = _get_clients()
     _, subnet_id, sg_id, iam_arn = _setup(ec2_client, iam_client)
 
+    instance_role = iam_arn.replace("role", "instance-profile") if use_arn_for_instance_role else iam_arn.split("/")[-1]
     compute_name = str(uuid4())
     resp = batch_client.create_compute_environment(
         computeEnvironmentName=compute_name,
@@ -28,7 +30,7 @@ def test_create_managed_compute_environment():
             "subnets": [subnet_id],
             "securityGroupIds": [sg_id],
             "ec2KeyPair": "string",
-            "instanceRole": iam_arn.replace("role", "instance-profile"),
+            "instanceRole": instance_role,
             "tags": {"string": "string"},
             "bidPercentage": 123,
             "spotIamFleetRole": "string",