Delay git config setup until after home links

Author: nikivdev

src/home.rs

@@ -60,18 +60,6 @@ pub fn run(opts: HomeOpts) -> Result<()> {
         }
     }
     let prefer_ssh = ssh::prefer_ssh();
-    match ssh::ensure_git_ssh_command() {
-        Ok(true) => println!("Configured git to use 1Password SSH agent."),
-        Ok(false) => {}
-        Err(err) => println!("warning: failed to configure git ssh: {}", err),
-    }
-    if !prefer_ssh {
-        match ssh::ensure_git_https_insteadof() {
-            Ok(true) => println!("Configured git to use HTTPS when SSH isn't available."),
-            Ok(false) => {}
-            Err(err) => println!("warning: failed to configure git https rewrites: {}", err),
-        }
-    }
     let home = dirs::home_dir().context("Could not find home directory")?;
     let config_dir = home.join("config");
     let repo = coerce_repo_scheme(parse_repo_input(&opts.repo)?, prefer_ssh);
@@ -101,6 +89,19 @@ pub fn run(opts: HomeOpts) -> Result<()> {
 
     let archived = archive_existing_configs(&config_dir)?;
     apply_config(&config_dir)?;
+
+    match ssh::ensure_git_ssh_command() {
+        Ok(true) => println!("Configured git to use 1Password SSH agent."),
+        Ok(false) => {}
+        Err(err) => println!("warning: failed to configure git ssh: {}", err),
+    }
+    if !prefer_ssh {
+        match ssh::ensure_git_https_insteadof() {
+            Ok(true) => println!("Configured git to use HTTPS when SSH isn't available."),
+            Ok(false) => {}
+            Err(err) => println!("warning: failed to configure git https rewrites: {}", err),
+        }
+    }
     ensure_kar_repo(&flow_bin, prefer_ssh)?;
 
     if !archived.is_empty() {

src/ssh.rs

@@ -85,6 +85,9 @@ pub fn ensure_ssh_env() {
 }
 
 pub fn ensure_git_ssh_command() -> Result<bool> {
+    if !git_config_writable() {
+        return Ok(false);
+    }
     let Some(sock) = preferred_agent_sock() else {
         return Ok(false);
     };
@@ -128,6 +131,9 @@ pub fn ensure_git_ssh_command_for_sock(sock: &Path, force: bool) -> Result<bool>
 }
 
 pub fn ensure_git_https_insteadof() -> Result<bool> {
+    if !git_config_writable() {
+        return Ok(false);
+    }
     let desired = ["git@github.com:", "ssh://git@github.com/"];
     let mut changed = false;
 
@@ -142,6 +148,9 @@ pub fn ensure_git_https_insteadof() -> Result<bool> {
 }
 
 pub fn clear_git_https_insteadof() -> Result<bool> {
+    if !git_config_writable() {
+        return Ok(false);
+    }
     let desired = ["git@github.com:", "ssh://git@github.com/"];
     let mut changed = false;
 
@@ -372,6 +381,33 @@ fn git_config_get(key: &str) -> Result<Option<String>> {
     Ok(Some(value))
 }
 
+fn git_config_writable() -> bool {
+    let home = match std::env::var_os("HOME") {
+        Some(val) => PathBuf::from(val),
+        None => return false,
+    };
+    if !home.is_dir() {
+        return false;
+    }
+
+    let path = home.join(".gitconfig");
+    let meta = match fs::symlink_metadata(&path) {
+        Ok(meta) => meta,
+        Err(_) => return true,
+    };
+    if meta.is_dir() {
+        return false;
+    }
+    if meta.file_type().is_symlink() {
+        match fs::metadata(&path) {
+            Ok(target_meta) => target_meta.is_file(),
+            Err(_) => false,
+        }
+    } else {
+        true
+    }
+}
+
 fn git_config_get_all(key: &str) -> Result<Vec<String>> {
     let output = Command::new("git")
         .args(["config", "--global", "--get-all", key])