Skip to content

Commit 103d86d

Browse files
committed
Switch from pyright to basedpyright
1 parent cc7ad22 commit 103d86d

5 files changed

Lines changed: 16 additions & 16 deletions

File tree

.github/workflows/ci-python-project.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ jobs:
3838
directory: ${{ inputs.directory }}
3939
task: check:mypy
4040

41-
check-pyright:
41+
check-basedpyright:
4242
if: always() && contains(fromJSON('["skipped", "success"]'), needs.uv-cache.result)
4343
needs: uv-cache
4444
uses: ./.github/workflows/mise-uv-task.yaml
4545
with:
4646
directory: ${{ inputs.directory }}
47-
task: check:pyright
47+
task: check:basedpyright
4848

4949
run-all:
5050
if: inputs.directory != 'aoc-main'
@@ -65,7 +65,7 @@ jobs:
6565
if: always()
6666
needs:
6767
- check-mypy
68-
- check-pyright
68+
- check-basedpyright
6969
- run-all
7070
- test-pytest
7171
runs-on: ubuntu-24.04

.github/workflows/ci.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ jobs:
8181
directory: .
8282
task: check:prettier
8383

84-
check-pyright-repo:
84+
check-basedpyright-repo:
8585
needs: mise-cache-ubuntu
8686
uses: ./.github/workflows/mise-task.yaml
8787
with:
8888
directory: .
89-
task: check:pyright-repo
89+
task: check:basedpyright-repo
9090

9191
check-ruff:
9292
needs: mise-cache-ubuntu
@@ -179,7 +179,7 @@ jobs:
179179
if: always()
180180
needs:
181181
- check-prettier
182-
- check-pyright-repo
182+
- check-basedpyright-repo
183183
- check-ruff
184184
- check-ruff-format
185185
- check-shellcheck

aoc-main/mise.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
[tasks.check]
55
depends = [
66
"check:mypy",
7-
"check:pyright",
7+
"check:basedpyright",
88
"check:pytest",
99
]
1010

@@ -16,8 +16,8 @@ pythonVersion=$(cat pyproject.toml | yq -p toml '.project.requires-python' | sed
1616
mypy --python-executable "${pythonExecutable}" --python-version "${pythonVersion}" .
1717
"""
1818

19-
[tasks."check:pyright"]
20-
run = "uv run pyright"
19+
[tasks."check:basedpyright"]
20+
run = "uv run basedpyright"
2121

2222
[tasks."check:pytest"]
2323
run = "uv run pytest"

mise.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ python = "3.14.3"
44
uv = "0.10.7"
55

66
# Common tools
7-
"npm:pyright" = "1.1.408"
7+
"npm:basedpyright" = "1.38.2"
88
"pipx:shellcheck-gha" = "0.1.2"
99
prettier = "3.6.2"
1010
ruff = "0.15.4"
@@ -69,7 +69,7 @@ shell = "sh -c"
6969
[tasks.check]
7070
depends = [
7171
"check:prettier",
72-
"check:pyright-repo",
72+
"check:basedpyright-repo",
7373
"check:ruff",
7474
"check:ruff:format",
7575
"check:shellcheck",
@@ -100,8 +100,8 @@ fi
100100
prettier --ignore-path=.gitignore --ignore-path=.prettierignore "$userIgnoreArg" --check .
101101
"""
102102

103-
[tasks."check:pyright-repo"]
104-
run = "pyright"
103+
[tasks."check:basedpyright-repo"]
104+
run = "basedpyright"
105105

106106
[tasks."check:ruff"]
107107
run = "ruff check"

solvers/python/mise.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
[tasks.check]
55
depends = [
66
"check:mypy",
7-
"check:pyright",
7+
"check:basedpyright",
88
"check:pytest",
99
]
1010

@@ -16,8 +16,8 @@ pythonVersion=$(cat pyproject.toml | yq -p toml '.project.requires-python' | sed
1616
mypy --python-executable "${pythonExecutable}" --python-version "${pythonVersion}" .
1717
"""
1818

19-
[tasks."check:pyright"]
20-
run = "uv run pyright"
19+
[tasks."check:basedpyright"]
20+
run = "uv run basedpyright"
2121

2222
[tasks."check:pytest"]
2323
run = "uv run pytest"

0 commit comments

Comments
 (0)