feat: Adds an option to run an asnyc function before a step is shown.#588
Closed
Maxie42 wants to merge 1 commit into
Closed
feat: Adds an option to run an asnyc function before a step is shown.#588Maxie42 wants to merge 1 commit into
Maxie42 wants to merge 1 commit into
Conversation
Maxie42
changed the title
nilbuild
force-pushed
the
master
branch
3 times, most recently
from
c649426 to
275b442
Compare
Owner
|
Thanks for the PR but this is already achievable through hooks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is a convenience feature to do async stuff before a certain step is shown, This ideally would allow the user to do async stuff in the app before the step is shown.
Could reach similar function with adding on the OnNextClick of the previous, and OnPrevClick of the following, but it's easier.
Additionally this also runs if we were to step directly into this step with driverObj.drive(1)