fix: calculate progress text after spread merge with current step#597
Closed
FarbrorGarbo wants to merge 1 commit into
Closed
fix: calculate progress text after spread merge with current step#597FarbrorGarbo wants to merge 1 commit into
FarbrorGarbo wants to merge 1 commit into
Conversation
nilbuild
force-pushed
the
master
branch
3 times, most recently
from
c649426 to
275b442
Compare
Owner
|
Thanks for the PR but I did it a bit differently in f7b7760 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the order of calculating the progressText for the current step. The calculation must be done after merging the global configuration with the configuration of the current step which is what you would expect.
How to reproduce the error:
Create a step config with the popover progressText like
progressText: "{{current}} localized text {{total}} done"When the step is shown, it renders the text just as "{{current}} localized text {{total}} done"
I made this PR as a Hacktoberfest contribution.
If you think my contribution is helpful, it would be awesome if you could add the
hacktoberfest-acceptedlabel to it.Totally fine if not — just wanted to ask. Thanks for a great project!