slightly faster

nilsauf · nilsauf · commit 256ea099c881 · 2026-03-05T23:15:05.000+01:00
diff --git a/FTMS.NET/Utils/ByteExtensions.cs b/FTMS.NET/Utils/ByteExtensions.cs
@@ -31,7 +31,10 @@ public static bool IsBitSet(this ReadOnlySpan<byte> data, int pos)
 	}
 
 	public static bool IsBitSet(this byte b, int pos)
-		=> pos < 0 || pos > 7 ? 
-			throw new IndexOutOfRangeException() : 
-			(b & 1 << pos) != 0;
+	{
+		if ((uint)pos > 7)
+			throw new IndexOutOfRangeException();
+
+		return ((b >> pos) & 1) != 0;
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,10 @@ public static bool IsBitSet(this ReadOnlySpan<byte> data, int pos)`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`public static bool IsBitSet(this byte b, int pos)`
`34`		`- => pos < 0 \|\| pos > 7 ?`
`35`		`- throw new IndexOutOfRangeException() :`
`36`		`- (b & 1 << pos) != 0;`
	`34`	`+ {`
	`35`	`+ if ((uint)pos > 7)`
	`36`	`+ throw new IndexOutOfRangeException();`
	`37`	`+`
	`38`	`+ return ((b >> pos) & 1) != 0;`
	`39`	`+ }`
`37`	`40`	`}`