Improve the system for handling nClass inheritance#90
Merged
Conversation
… still in interim names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has several pieces:
nClass(via itsNC_InternalsClass) containall_methodName_to_cpp_code_nameto track the C++ version of method names obtained from base classes.cpp_code_namenot always get a unique suffix.genericInterfaceBaseCvia aninterface_resolver<>, which in turn allows base classes to be interfaced from R separately from their derived classes.shared_ptrin C++.The delayed handling of inheritance happens in three steps, from
nCompile:connect_inheritfor eachnClass. This lets everyone find their base classes.process_inheritfor eachnClass. This pulls together method names from base classes.NC_check_inheritancefor eachnClass. This checks for (disallowed by default) method overloading and mismatched method signatures (there are nOptions to control these rules).