Fix various issues in initializing nimOptim, plus use of Laplace updateSettings (#1581)

* Revise formatting of new addSampler allowData messaging.

* Fix nimOptimDefaultControl default types.
Ensure fnscale=-1 in inner Laplace when using updateSettings.
Use `working_maxit` consistently in nimOptim solve.

Author: paciorek

packages/nimble/R/Laplace.R

@@ -323,6 +323,7 @@ buildOneAGHQuad1D <- nimbleFunction(
       ##   transMethod <<- gridType
       ## }
       if(replace_optimControl) {
+        optimControl$fnscale <- -1
         optimControl_ <<- optimControl
       }
     },
@@ -1163,6 +1164,7 @@ buildOneAGHQuad <- nimbleFunction(
         transMethod <<- gridType
       }
       if(replace_optimControl) {
+        optimControl$fnscale <- -1   
         optimControl_ <<- optimControl
       }
     },

packages/nimble/R/nimbleFunction_Rexecution.R

@@ -1497,15 +1497,15 @@ nimOptimDefaultControl <- function() {
   control <- optimControlNimbleList$new()
   control$trace <- 0
   control$fnscale <- 1
-  control$parscale <- NA # Must be filled in to length of par
-  control$ndeps <- NA    # Ditto
-  control$maxit <- NA  ## The default value depends on method.
+  control$parscale <- as.numeric(NA) # Must be filled in to length of par
+  control$ndeps <- as.numeric(NA)    # Ditto
+  control$maxit <- as.integer(NA)  ## The default value depends on method.
   control$abstol = -Inf
   control$reltol <- sqrt(.Machine$double.eps)
   control$alpha <- 1.0
   control$beta <- 0.5
   control$gamma <- 2.0
-  control$REPORT <- NA # Method dependent and not used in compiled version
+  control$REPORT <- as.integer(NA) # Method dependent and not used in compiled version
   control$type <- 1
   control$lmm <- 5
   control$factr <- 1e7

packages/nimble/inst/CppCode/nimOptim.cpp

@@ -185,6 +185,7 @@ nimSmartPtr<OptimResultNimbleList> NimOptimProblem::solve(
         result->hessian.initialize(NA_REAL, true, n, n);
     }
 
+
     // Parameters common to all methods.
     double* dpar = par.getPtr();
     double* X = result->par.getPtr();
@@ -248,7 +249,7 @@ nimSmartPtr<OptimResultNimbleList> NimOptimProblem::solve(
             SEXP Scontrol = PROTECT(Rf_allocVector(VECSXP, 6));
             SET_VECTOR_ELT(Scontrol, 0, PROTECT(double_2_SEXP(control_->abstol)));
             SET_VECTOR_ELT(Scontrol, 1, PROTECT(double_2_SEXP(control_->reltol)));
-            SET_VECTOR_ELT(Scontrol, 2, PROTECT(int_2_SEXP(control_->maxit)));
+            SET_VECTOR_ELT(Scontrol, 2, PROTECT(int_2_SEXP(working_maxit)));
             SET_VECTOR_ELT(Scontrol, 3, PROTECT(NimArr_2_SEXP<1>(working_parscale)));
             SET_VECTOR_ELT(Scontrol, 4, PROTECT(double_2_SEXP(control_->fnscale)));
             SET_VECTOR_ELT(Scontrol, 5, PROTECT(int_2_SEXP(control_->trace)));
@@ -321,7 +322,6 @@ nimSmartPtr<OptimResultNimbleList> NimOptimProblem::solve(
         //  NIMERROR("Unknown method_: %s", method_.c_str());
         //}
     result->value *= control_->fnscale;
-
     // Compute Hessian.
     // Parameters are still on the optimization scale,
     // i.e. divided by parscale