Adds Parent/Child relationship to Contact Groups.

Author: fr3nch13

lib/netbox_client_ruby/api/tenancy/contact_group.rb

@@ -9,6 +9,7 @@ class ContactGroup
       deletable true
       path 'tenancy/contact-groups/:id/'
       creation_path 'tenancy/contact-groups/'
+      object_fields parent: proc { |raw_data| ContactGroup.new raw_data['id'] }
     end
   end
 end

spec/fixtures/tenancy/contact-group_1.json

@@ -1,8 +1,7 @@
 {
   "id": 1,
-  "display": "Customer",
-  "name": "Customer",
-  "slug": "customer",
-  "description": "Customer contact group",
-  "parent": null
+  "display": "Parent Customers",
+  "name": "Parent Customers",
+  "slug": "parent-customers",
+  "description": "Parent Contact contact group"
 }

spec/fixtures/tenancy/contact-group_2.json

@@ -0,0 +1,15 @@
+{
+  "id": 2,
+  "display": "Child Customers",
+  "name": "Child Customers",
+  "slug": "child-customers",
+  "description": "Child contact group",
+  "parent": {
+    "id": 1,
+    "url": "http://localhost/api/tenancy/contact_groups/1/",
+    "display": "Parent Customers",
+    "name": "Parent Customers",
+    "slug": "parent-customers",
+    "description": "Parent Contact contact group"
+  }
+}

spec/fixtures/tenancy/contact-groups.json

@@ -1,15 +1,30 @@
 {
-  "count": 1,
+  "count": 2,
   "next": null,
   "previous": null,
   "results": [
     {
       "id": 1,
-      "display": "Customer",
-      "name": "Customer",
-      "slug": "customer",
-      "description": "Customer contact group",
+      "display": "Customers",
+      "name": "Customers",
+      "slug": "customers",
+      "description": "Parent Contact contact group",
       "parent": null
+    },
+    {
+      "id": 2,
+      "display": "East Coast Customers",
+      "name": "East Coast Customers",
+      "slug": "east-coast-customers",
+      "description": "Child contact group",
+      "parent": {
+        "id": 1,
+        "url": "http://localhost/api/tenancy/contact_groups/1/",
+        "display": "Customers",
+        "name": "Customers",
+        "slug": "customers",
+        "description": "Parent Contact contact group"
+      }
     }
   ]
 }

spec/netbox_client_ruby/api/tenancy/contact_group_spec.rb

@@ -24,7 +24,23 @@
     end
 
     it 'shall be the expected name' do
-      expect(subject.name).to eq('Customer')
+      expect(subject.name).to eq('Parent Customers')
+    end
+  end
+
+  describe '.parent' do
+    it 'should be nil' do
+      expect(subject.parent).to be_nil
+    end
+
+    context 'Child Contact Group' do
+      let(:contact_group_id) { 2 }
+
+      it 'should be a Contact Group object' do
+        parent_contact_group = subject.parent
+        expect(parent_contact_group).to be_a NetboxClientRuby::Tenancy::ContactGroup
+        expect(parent_contact_group.id).to eq(1)
+      end
     end
   end
 
@@ -45,7 +61,7 @@
 
     it 'should update the object' do
       expect(faraday).to receive(request_method).and_call_original
-      expect(subject.update(name: 'noob').name).to eq('Customer')
+      expect(subject.update(name: 'noob').name).to eq('Parent Customers')
     end
   end
 
@@ -91,8 +107,8 @@
         expect(faraday).to receive(request_method).and_call_original
 
         subject.save
-        expect(subject.name).to eq('Customer')
-        expect(subject.slug).to eq('customer')
+        expect(subject.name).to eq('Parent Customers')
+        expect(subject.slug).to eq('parent-customers')
       end
     end
 
@@ -127,8 +143,8 @@
         subject.save
 
         expect(subject.id).to be(1)
-        expect(subject.name).to eq('Customer')
-        expect(subject.slug).to eq('customer')
+        expect(subject.name).to eq('Parent Customers')
+        expect(subject.slug).to eq('parent-customers')
       end
     end
   end

spec/netbox_client_ruby/api/tenancy/contacts_groups_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe NetboxClientRuby::Tenancy::ContactGroups, faraday_stub: true do
-  let(:expected_number_of_items) { 1 }
+  let(:expected_number_of_items) { 2 }
   let(:expected_singular_type) { NetboxClientRuby::Tenancy::ContactGroup }
 
   let(:response) { File.read('spec/fixtures/tenancy/contact-groups.json') }