Skip to content

Commit ec84d59

Browse files
committed
build: don't deprecate ruby2.7 & faraday < 1
1 parent dc8b28e commit ec84d59

4 files changed

Lines changed: 33 additions & 5 deletions

File tree

.github/workflows/rspec.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,22 @@ jobs:
1515
matrix:
1616
os: [ubuntu-latest]
1717
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
18-
ruby: ['3.0', '3.1', '3.2', '3.3']
18+
ruby: ['2.7', '3.0', '3.1', '3.2', '3.3']
1919
gemfile:
2020
[
2121
'gemfiles/faraday1.gemfile',
2222
'gemfiles/faraday2.gemfile',
2323
]
24+
# Faraday 0.x with Ruby 3.x not supported
25+
exclude:
26+
- ruby: '3.0'
27+
gemfile: gemfiles/faraday0.gemfile
28+
- ruby: '3.1'
29+
gemfile: gemfiles/faraday0.gemfile
30+
- ruby: '3.2'
31+
gemfile: gemfiles/faraday0.gemfile
32+
- ruby: '3.3'
33+
gemfile: gemfiles/faraday0.gemfile
2434
runs-on: ${{ matrix.os }}
2535
env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
2636
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}

Appraisals

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# frozen_string_literal: true
22

3+
appraise 'faraday0' do
4+
gem 'faraday', '< 1.0'
5+
gem 'faraday_middleware', '< 1'
6+
end
7+
38
appraise 'faraday1' do
49
gem 'faraday', '= 1.0'
510
gem 'faraday_middleware', '< 2'

bin/setup

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,4 @@ IFS=$'\n\t'
44
set -vx
55

66
bundle install
7-
8-
for filename in gemfiles/*.gemfile; do
9-
BUNDLE_GEMFILE=$filename bundle install
10-
done
7+
bundle exec appraisal install

gemfiles/faraday0.gemfile

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# This file was generated by Appraisal
2+
3+
source "https://rubygems.org"
4+
5+
gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
6+
gem "pry"
7+
gem "rake"
8+
gem "rspec"
9+
gem "rubocop"
10+
gem "rubocop-performance"
11+
gem "rubocop-rake"
12+
gem "rubocop-rspec"
13+
gem "faraday", "< 1.0"
14+
gem "faraday_middleware", "< 1"
15+
16+
gemspec path: "../"

0 commit comments

Comments
 (0)