Skip to content

ci: stop requiring PR numbers in changelog#26

Merged
ningzimu merged 1 commit into
mainfrom
ci/remove-changelog-pr-number-requirement
May 19, 2026
Merged

ci: stop requiring PR numbers in changelog#26
ningzimu merged 1 commit into
mainfrom
ci/remove-changelog-pr-number-requirement

Conversation

@ningzimu
Copy link
Copy Markdown
Owner

Summary

  • remove the requirement that changelog entries include the PR number
  • keep validation that required changelog entries are added under ## Unreleased in a ### subsection

Test

  • workflow logic change only; not run locally

@ningzimu ningzimu merged commit 6bc0986 into main May 19, 2026
2 checks passed
@ningzimu ningzimu deleted the ci/remove-changelog-pr-number-requirement branch May 19, 2026 16:22
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ca1f7308c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 83 to +85
if (line.startsWith("+")) {
const text = line.slice(1);
if (text.includes(prToken)) {
addedPrLines.push({ line: currentLine, text });
}
addedLines.push({ line: currentLine, text });
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Exclude subsection headers from changelog entry validation

This change now records every added CHANGELOG.md line and validates each as if it were an entry line. In an empty ## Unreleased block (a common post-release state), adding the first subsection header like ### Features will fail because that header has no preceding ### to satisfy the subsection lookup, triggering Changelog PR entry must be inside a ### subsection. As a result, valid PRs can be blocked even when they add a properly formatted entry under ## Unreleased.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant