Support krunkit new virtio-net unixgram options#92
Merged
Conversation
nirs
force-pushed
the
krunkit-no-offloading
branch
from
fef1065 to
708874d
Compare
Future krunkit provides unixgram socket option supporting offloading argument to enable of disable offloading. This is a minimal change to test this option. Depends on: - libkrun/krunkit#63
Latest krunkit can use a file descriptor instead of unix socket. Update the krunkit command to support this. Since krunkit behaves like vfkit and qemu, we can remove the special "auto" connection. Depends on: - libkrun/krunkit#63 - containers/libkrun#402
Previously we use "auto", "on", "off" to enable offloading automatically for krunkit since it was always required. Now that this is an optional features we can simplify to boolean flag. Depends on: - libkrun/krunkit#63 - containers/libkrun#402
nirs
force-pushed
the
krunkit-no-offloading
branch
from
2462708 to
2253989
Compare
Matching other boolean flags and the option name in krunkit. Update the
benchmarks to use "offloading" instead of "offload" and use a boolean
option instead of string ("on", "off").
Since krunkit supports now testing with and without offloading, update
the benchmark to test with system krunkit instead of krunkit.local.
Update the plots to compare krunkit with and without offloading. Since
the default is not using offloading, change the tag to "offload".
host mode fails randomly with vfkit and krunkit when testing vm-to-vm. This mode is less interesting so lets disable it for now. We could work on retries or skip it only for certain drivers later.
Latest krunkit support the offloading option to enable and disable offloading. This improves performance dramatically for host to vm use case. Update the results using latest krunkit with and without offloading on macOS 15.6.1. Since offloading is a useful option now, add an offloading section to the README. Show both shared and bridged network results for all tests. Bridged performance is little better but most users are interested in shared network results. For example minikube does not support yet bridged network due to the way it discover machine IP address.
nirs
force-pushed
the
krunkit-no-offloading
branch
from
34b0bc0 to
b3e60fa
Compare
These options can be used for latest krunkit and may be useful in certain use cases.
nirs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest krunkit supports virtio-net type=unixgram options supporting fd= or path= and offloading= option to enable offloading. This change update the example script to use the new options.
--connection=fdfor krunkit driver and make it the default--connection=autooption since all drivers supports--connection=fd--vment-offload=auto|on|offto--enable-offloading booleanflag since all drivers disable offloading by defaultoffloadingoptionDepends on: