Added small update to sample app#307
Closed
Thanus31 wants to merge 11 commits into
Closed
Conversation
Added a comment to the Hello World Workflow file.
There was a problem hiding this comment.
Pull request overview
This PR updates repository documentation and adjusts/adds GitHub Actions workflows used for the learning sample app and tasks.
Changes:
- Adds minor README text to the root README and the sample app README.
- Adds two new example workflows (
custom.yml,conditional.yml) for learning exercises. - Significantly rewrites the existing
build-test.ymlworkflow (triggers, matrix, steps, artifacts).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
sample-app/README.md |
Adds a short trailing documentation line in the sample app README. |
README.md |
Adds a short trailing tagline and extra blank lines at the end of the root README. |
.github/workflows/hello-world.yml |
Adds a new comment line near the top of the workflow. |
.github/workflows/custom.yml |
Introduces a new workflow that runs tests on pushes to develop, including env vars and a secrets-related step. |
.github/workflows/conditional.yml |
Introduces a new workflow demonstrating conditional step execution based on branch. |
.github/workflows/build-test.yml |
Replaces the prior build/test pipeline with a simpler develop-only workflow that runs tests, uploads an artifact, and downloads it in a dependent job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
+15
| strategy: | ||
| matrix: | ||
| node-version: [16.x, 18.x] | ||
| node-version: [22.x] | ||
|
|
| branches: [main] | ||
| workflow_dispatch: | ||
| branches: | ||
| - develop |
Comment on lines
12
to
+15
| strategy: | ||
| matrix: | ||
| node-version: [16.x, 18.x] | ||
| node-version: [22.x] | ||
|
|
| env: | ||
| TEST_SECRET: ${{ secrets.TEST_SECRET }} | ||
| run: | | ||
| echo "Secret loaded successfully" |
Comment on lines
+157
to
159
| Updated sample app documentation | ||
|
|
||
| **Happy learning! 🎓** |
Comment on lines
610
to
614
|
|
||
| Learning GitHub Actions 🚀 | ||
|
|
||
|
|
||
|
|
Comment on lines
+1
to
7
| name: Build Test Workflow | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, develop] | ||
| paths: | ||
| - 'sample-app/**' | ||
| - '.github/workflows/build-test.yml' | ||
| pull_request: | ||
| branches: [main] | ||
| workflow_dispatch: | ||
| branches: | ||
| - develop | ||
|
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes updates related to GitHub Actions learning tasks.
Changes Made
Fixes # (issue)
Type of Change
How Has This Been Tested?
Test Configuration
Checklist
Screenshots or Workflow Logs
Workflow runs were verified successfully in the GitHub Actions tab.
Additional Context
This PR was created as part of GitHub Actions practice and learning activities.