Commit 74e5ad1
authored
fix(inventory): address review feedback on area path counts (#124)
## Summary
Follow-up to #123 addressing CodeRabbit and Codex review feedback.
- **Case-sensitive comparer**: `AreaPathCounts` now uses the default
case-sensitive comparer — Azure DevOps area paths are case-sensitive and
`OrdinalIgnoreCase` would silently merge distinct paths
- **Resume fix**: `inventory-areapath.csv` is now reloaded on resume so
previously-collected rows are not overwritten when an interrupted
inventory run is retried
- **Unused import**: Removed `using System.Collections.ObjectModel` from
`InventoryReport.cs`
Note: the `GetValueOrDefault` nitpick was not applied — the TFS Object
Model project targets `net481` where that method is unavailable;
`TryGetValue` is kept there.
## Test plan
- [x] All 1022 tests passing (`dotnet test`)
- [x] Full solution builds with 0 errors
🤖 Generated with [Claude Code](https://claude.com/claude-code)3 files changed
Lines changed: 14 additions & 2 deletions
File tree
- src
- DevOpsMigrationPlatform.Abstractions.Agent/Discovery
- DevOpsMigrationPlatform.Abstractions/ControlPlaneApi
- DevOpsMigrationPlatform.Infrastructure.Agent/Discovery
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
157 | 170 | | |
158 | 171 | | |
159 | 172 | | |
| |||
0 commit comments