remove minInputLength option in favour of minDecodedLength

Author: nklapste

src/main/java/jadx/plugins/stringdecoder/B64DeobfuscateOptions.java

@@ -7,7 +7,6 @@ public class B64DeobfuscateOptions extends BasePluginOptionsBuilder {
 	private boolean enable;
 	private boolean enableByteArrayStringPass;
 	private int byteArrayMinPrintablePercent;
-	private int minInputLength;
 	private int minDecodedLength;
 	private int maxCommentLength;
 	private int minPrintablePercent;
@@ -23,19 +22,14 @@ public void registerOptions() {
 				.defaultValue(100)
 				.setter(v -> maxCommentLength = v);
 		intOption(JadxStringDecoderPlugin.PLUGIN_ID + ".minDecodedLength")
-				.description("Minimum decoded string length to add a comment (0 = disabled); rejects very short decoded outputs")
+				.description("Minimum decoded string length to add a comment (0 = disabled); helps reject short garbage decodes")
 				.defaultValue(0)
 				.setter(v -> minDecodedLength = v);
-
 		// B64DeobfuscatePass options
 		boolOption(JadxStringDecoderPlugin.PLUGIN_ID + ".enableB64DecodePass")
 				.description("Enable Base64 string detection and decoding")
 				.defaultValue(true)
 				.setter(v -> enable = v);
-		intOption(JadxStringDecoderPlugin.PLUGIN_ID + ".minInputLength")
-				.description("Minimum length of an encoded string to be considered for decoding")
-				.defaultValue(8)
-				.setter(v -> minInputLength = v);
 		intOption(JadxStringDecoderPlugin.PLUGIN_ID + ".minPrintablePercent")
 				.description("Minimum percentage of printable ASCII chars in decoded string (0-100); higher values reduce false positives")
 				.defaultValue(90)
@@ -76,10 +70,6 @@ public double getByteArrayMinPrintableRatio() {
 		return byteArrayMinPrintablePercent / 100.0;
 	}
 
-	public int getMinInputLength() {
-		return minInputLength;
-	}
-
 	public int getMaxCommentLength() {
 		return maxCommentLength;
 	}

src/main/java/jadx/plugins/stringdecoder/B64Detector.java

@@ -31,9 +31,6 @@ public static B64Result detect(String str, B64DeobfuscateOptions options) {
 		if (B64FalsePositives.contains(str)) {
 			return null;
 		}
-		if (str.length() < options.getMinInputLength()) {
-			return null;
-		}
 		if (options.isRequireValidLength() && str.length() % 4 != 0) {
 			return null;
 		}

src/main/java/jadx/plugins/stringdecoder/ByteArrayStringPass.java

@@ -63,7 +63,7 @@ private void processField(FieldNode field) {
 			return;
 		}
 		byte[] bytes = extractLiteralBytes(filledArr);
-		if (bytes == null || bytes.length < Math.max(1, options.getMinInputLength())) {
+		if (bytes == null || bytes.length == 0) {
 			return;
 		}
 		String decoded = tryDecodeAsString(bytes);

src/main/java/jadx/plugins/stringdecoder/JadxStringDecoderPlugin.java

@@ -88,7 +88,7 @@ public String getTitle() {
 			@Override
 			public JComponent buildComponent() {
 				if (panel == null) {
-					Set<String> generalSuffixes = Set.of("minInputLength", "maxCommentLength", "minDecodedLength");
+					Set<String> generalSuffixes = Set.of("maxCommentLength", "minDecodedLength");
 					List<OptionDescription> allOpts = options.getOptionsDescriptions();
 					List<OptionDescription> generalOpts = allOpts.stream()
 							.filter(o -> generalSuffixes.stream().anyMatch(s -> o.name().endsWith("." + s)))

src/test/java/jadx/plugins/stringdecoder/JadxStringDecoderPluginTest.java

@@ -154,22 +154,14 @@ public void requireValidLengthAllowsDivisibleByFourTest() throws Exception {
 		assertThat(code).contains("b64: hello");
 	}
 
-	@Test
-	public void minInputLengthOptionTest() throws Exception {
-		// Raising minInputLength to 24 should suppress the 8-char "aGVsbG8=" string
-		String code = decompileSmali("b64/b64_decodable.smali",
-				Map.of(opt("minInputLength"), "24"));
-		System.out.println(code);
-		assertThat(code).doesNotContain("b64:");
-	}
-
 	@Test
 	public void minAlphanumericPercentOptionTest() throws Exception {
 		// "fillItem" decodes to ~40% alphanumeric; setting minAlphanumericPercent=50 must suppress it
-		// (set printable threshold low enough to isolate the alnum check)
+		// (lower printable threshold and disable skipCamelCase to isolate the alnum check)
 		String code = decompileSmali("b64/identifier_like_b64.smali",
 				Map.of(opt("minPrintablePercent"), "75",
-						opt("minAlphanumericPercent"), "50"));
+						opt("minAlphanumericPercent"), "50",
+						opt("skipCamelCase"), "false"));
 		System.out.println(code);
 		assertThat(code).doesNotContain("b64:");
 	}