Add comment regarding #4767 (#4770)

nlohmann · web-flow · commit 0a8b48ac6a89 · 2025-05-04T10:27:58.000+02:00
* 💡 add comment regarding #4767 Signed-off-by: Niels Lohmann <mail@nlohmann.me> * ✏️ address review comments Signed-off-by: Niels Lohmann <mail@nlohmann.me> * ✏️ address review comments Signed-off-by: Niels Lohmann <mail@nlohmann.me> --------- Signed-off-by: Niels Lohmann <mail@nlohmann.me>
diff --git a/tests/src/unit-locale-cpp.cpp b/tests/src/unit-locale-cpp.cpp
@@ -139,7 +139,12 @@ TEST_CASE("locale-dependent test (LC_NUMERIC=de_DE)")
         {
             std::array<char, 6> buffer = {};
             CHECK(std::snprintf(buffer.data(), buffer.size(), "%.2f", 12.34) == 5); // NOLINT(cppcoreguidelines-pro-type-vararg,hicpp-vararg)
-            CHECK(std::string(buffer.data()) == "12,34");
+            const auto snprintf_result = std::string(buffer.data());
+            if (snprintf_result != "12,34")
+            {
+                CAPTURE(snprintf_result)
+                MESSAGE("To test if number parsing is locale-independent, we set the locale to de_DE. However, on this system, the decimal separator doesn't change to `,` potentially due to a known musl issue (https://github.com/nlohmann/json/issues/4767).");
+            }
         }
 
         SECTION("parsing")

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,12 @@ TEST_CASE("locale-dependent test (LC_NUMERIC=de_DE)")`
`139`	`139`	`{`
`140`	`140`	`std::array<char, 6> buffer = {};`
`141`	`141`	`CHECK(std::snprintf(buffer.data(), buffer.size(), "%.2f", 12.34) == 5); // NOLINT(cppcoreguidelines-pro-type-vararg,hicpp-vararg)`
`142`		`- CHECK(std::string(buffer.data()) == "12,34");`
	`142`	`+ const auto snprintf_result = std::string(buffer.data());`
	`143`	`+ if (snprintf_result != "12,34")`
	`144`	`+ {`
	`145`	`+ CAPTURE(snprintf_result)`
	`146`	+ MESSAGE("To test if number parsing is locale-independent, we set the locale to de_DE. However, on this system, the decimal separator doesn't change to `,` potentially due to a known musl issue (https://github.com/nlohmann/json/issues/4767).");
	`147`	`+ }`
`143`	`148`	`}`
`144`	`149`
`145`	`150`	`SECTION("parsing")`