Fix compilation failure and warnings with NVHPC (#4744)

nlohmann · web-flow · commit 88c92e605c7b · 2025-04-16T16:09:21.000+02:00
* 🚨 fix warnings

Signed-off-by: Niels Lohmann &lt;mail@nlohmann.me&gt;

* 🚨 fix warnings

Signed-off-by: Niels Lohmann &lt;mail@nlohmann.me&gt;

* ⚗️ enable ranges support

Signed-off-by: Niels Lohmann &lt;mail@nlohmann.me&gt;

* 🔥 remove ci_nvhpc job

Signed-off-by: Niels Lohmann &lt;mail@nlohmann.me&gt;

* ⚗️ enable ranges support

Signed-off-by: Niels Lohmann &lt;mail@nlohmann.me&gt;

* 🔥 remove ci_nvhpc job

Signed-off-by: Niels Lohmann &lt;mail@nlohmann.me&gt;

* 🚨 fix warning

Signed-off-by: Niels Lohmann &lt;mail@nlohmann.me&gt;

---------

Signed-off-by: Niels Lohmann &lt;mail@nlohmann.me&gt;
diff --git a/docs/mkdocs/docs/community/quality_assurance.md b/docs/mkdocs/docs/community/quality_assurance.md
@@ -76,6 +76,7 @@ violations will result in a failed build.
         | GNU 13.3.0                                   | x86_64       | Ubuntu 22.04.1 LTS       | GitHub    |
         | GNU 14.2.0                                   | x86_64       | Ubuntu 22.04.1 LTS       | GitHub    |
         | GNU 14.2.0                                   | arm64        | Linux 6.1.100            | Cirrus CI |
+        | icpc (ICC) 2021.5.0 20211109                 | x86_64       | Ubuntu 20.04.3 LTS       | GitHub    |
         | MSVC 19.0.24241.7                            | x86          | Windows 8.1              | AppVeyor  |
         | MSVC 19.16.27035.0                           | x86          | Windows-10 (Build 14393) | AppVeyor  |
         | MSVC 19.29.30157.0                           | x86          | Windows 10 (Build 17763) | GitHub    |
diff --git a/include/nlohmann/detail/output/binary_writer.hpp b/include/nlohmann/detail/output/binary_writer.hpp
@@ -973,9 +973,9 @@ class binary_writer
         if (JSON_HEDLEY_UNLIKELY(it != BasicJsonType::string_t::npos))
         {
             JSON_THROW(out_of_range::create(409, concat("BSON key cannot contain code point U+0000 (at byte ", std::to_string(it), ")"), &j));
-            static_cast<void>(j);
         }
 
+        static_cast<void>(j);
         return /*id*/ 1ul + name.size() + /*zero-terminator*/1u;
     }
 
diff --git a/single_include/nlohmann/json.hpp b/single_include/nlohmann/json.hpp
@@ -16712,9 +16712,9 @@ class binary_writer
         if (JSON_HEDLEY_UNLIKELY(it != BasicJsonType::string_t::npos))
         {
             JSON_THROW(out_of_range::create(409, concat("BSON key cannot contain code point U+0000 (at byte ", std::to_string(it), ")"), &j));
-            static_cast<void>(j);
         }
 
+        static_cast<void>(j);
         return /*id*/ 1ul + name.size() + /*zero-terminator*/1u;
     }
 
diff --git a/tests/src/unit-iterators2.cpp b/tests/src/unit-iterators2.cpp
@@ -955,7 +955,8 @@ TEST_CASE("iterators 2")
                 };
                 json j_expected{"a_key", "b_key", "c_key"};
 
-                auto transformed = j.items() | std::views::transform([](const auto & item)
+                // NOLINTNEXTLINE(fuchsia-trailing-return)
+                auto transformed = j.items() | std::views::transform([](const auto & item) -> std::string_view
                 {
                     return item.key();
                 });
diff --git a/tests/src/unit-regression2.cpp b/tests/src/unit-regression2.cpp
@@ -566,7 +566,7 @@ TEST_CASE("regression tests 2")
             const auto length = 300;
 
             json dump_test;
-            dump_test["1"] = std::string(length, -1);
+            dump_test["1"] = std::string(length, static_cast<std::string::value_type>(-1));
 
             std::string expected = R"({"1":")";
             for (int i = 0; i < length; ++i)
@@ -583,7 +583,7 @@ TEST_CASE("regression tests 2")
             const auto length = 500;
 
             json dump_test;
-            dump_test["1"] = std::string(length, -2);
+            dump_test["1"] = std::string(length, static_cast<std::string::value_type>(-2));
 
             std::string expected = R"({"1":")";
             for (int i = 0; i < length; ++i)
diff --git a/tests/src/unit-udt.cpp b/tests/src/unit-udt.cpp
@@ -841,7 +841,7 @@ class Evil
   public:
     Evil() = default;
     template <typename T>
-    Evil(T t) : m_i(sizeof(t))
+    Evil(const T& t) : m_i(sizeof(t))
     {
         static_cast<void>(t); // fix MSVC's C4100 warning
     }
@@ -863,6 +863,10 @@ TEST_CASE("Issue #924")
     // silence Wunused-template warnings
     Evil e(1);
     CHECK(e.m_i >= 0);
+
+    // suppress warning: function "<unnamed>::Evil::Evil(T) [with T=std::string]" was declared but never referenced [declared_but_not_referenced]
+    Evil e2(std::string("foo"));
+    CHECK(e2.m_i >= 0);
 }
 
 TEST_CASE("Issue #1237")

Original file line number	Diff line number	Diff line change
`@@ -973,9 +973,9 @@ class binary_writer`
`973`	`973`	`if (JSON_HEDLEY_UNLIKELY(it != BasicJsonType::string_t::npos))`
`974`	`974`	`{`
`975`	`975`	`JSON_THROW(out_of_range::create(409, concat("BSON key cannot contain code point U+0000 (at byte ", std::to_string(it), ")"), &j));`
`976`		`- static_cast<void>(j);`
`977`	`976`	`}`
`978`	`977`
	`978`	`+ static_cast<void>(j);`
`979`	`979`	`return /id/ 1ul + name.size() + /zero-terminator/1u;`
`980`	`980`	`}`
`981`	`981`
Original file line number	Diff line number	Diff line change
`@@ -16712,9 +16712,9 @@ class binary_writer`
`16712`	`16712`	`if (JSON_HEDLEY_UNLIKELY(it != BasicJsonType::string_t::npos))`
`16713`	`16713`	`{`
`16714`	`16714`	`JSON_THROW(out_of_range::create(409, concat("BSON key cannot contain code point U+0000 (at byte ", std::to_string(it), ")"), &j));`
`16715`		`- static_cast<void>(j);`
`16716`	`16715`	`}`
`16717`	`16716`
	`16717`	`+ static_cast<void>(j);`
`16718`	`16718`	`return /id/ 1ul + name.size() + /zero-terminator/1u;`
`16719`	`16719`	`}`
`16720`	`16720`
Original file line number	Diff line number	Diff line change
`@@ -955,7 +955,8 @@ TEST_CASE("iterators 2")`
`955`	`955`	`};`
`956`	`956`	`json j_expected{"a_key", "b_key", "c_key"};`
`957`	`957`
`958`		`- auto transformed = j.items() \| std::views::transform([](const auto & item)`
	`958`	`+ // NOLINTNEXTLINE(fuchsia-trailing-return)`
	`959`	`+ auto transformed = j.items() \| std::views::transform([](const auto & item) -> std::string_view`
`959`	`960`	`{`
`960`	`961`	`return item.key();`
`961`	`962`	`});`
Original file line number	Diff line number	Diff line change
`@@ -841,7 +841,7 @@ class Evil`
`841`	`841`	`public:`
`842`	`842`	`Evil() = default;`
`843`	`843`	`template <typename T>`
`844`		`- Evil(T t) : m_i(sizeof(t))`
	`844`	`+ Evil(const T& t) : m_i(sizeof(t))`
`845`	`845`	`{`
`846`	`846`	`static_cast<void>(t); // fix MSVC's C4100 warning`
`847`	`847`	`}`
`@@ -863,6 +863,10 @@ TEST_CASE("Issue #924")`
`863`	`863`	`// silence Wunused-template warnings`
`864`	`864`	`Evil e(1);`
`865`	`865`	`CHECK(e.m_i >= 0);`
	`866`	`+`
	`867`	`+ // suppress warning: function "<unnamed>::Evil::Evil(T) [with T=std::string]" was declared but never referenced [declared_but_not_referenced]`
	`868`	`+ Evil e2(std::string("foo"));`
	`869`	`+ CHECK(e2.m_i >= 0);`
`866`	`870`	`}`
`867`	`871`
`868`	`872`	`TEST_CASE("Issue #1237")`