Fix for printing long doubles bug in dump_float by RUSLoker · Pull Request #3929 · nlohmann/json

RUSLoker · 2023-01-25T15:35:47Z

When you use long double as a floating point type with the current version of include/nlohmann/detail/output/serializer.hpp and try to dump json it prints trash instead of actual number. This if-else fixes the problem. On using long double you just need to add an 'L' modifier before 'g' in format string.

When you use long double as a floating point type with the current version of this file and try to dump json it prints trash instead of actual number. This if-else fixes the problem. On using long double you just need to add an 'L' modifier before 'g' in format string. Signed-off-by: Kirill Lokotkov <klokotkov@ya.ru>

github-actions · 2023-01-25T15:36:29Z

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines.

nlohmann

The library targets C++11. Please adjust the code.

Signed-off-by: Kirill Lokotkov <klokotkov@ya.ru>

github-actions · 2023-01-25T15:51:08Z

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines.

Signed-off-by: Kirill Lokotkov <klokotkov@ya.ru>

github-actions · 2023-01-25T16:04:43Z

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @RUSLoker Please read and follow the Contribution Guidelines.

Signed-off-by: rusloker <klokotkov@ya.ru>

coveralls · 2023-01-26T09:27:31Z

coverage: 100.0%. remained the same
when pulling cf5c7fb on RUSLoker:patch-1
into a259ecc on nlohmann:develop.

gregmarr

LGTM, @nlohmann will need to merge.

t-b · 2023-01-26T16:02:15Z

I think a test is missing or?

nlohmann · 2023-01-26T19:26:24Z

Yes, a test is definitely required.

There is also #3906 that I need to take care of to finally have a green CI again. I'm busy right now, so sorry for delays.

nlohmann · 2023-01-31T18:25:24Z

Please update to recent develop version - the CI is fixed there (see #3906).

RUSLoker · 2023-02-01T11:27:54Z

@nlohmann, it asks for your approval to run CI workflows.

RUSLoker · 2023-02-01T13:44:29Z

@nlohmann, @gregmarr, what's wrong with Cirrus CI / check?

nlohmann · 2023-02-01T14:20:28Z

@nlohmann, @gregmarr, what's wrong with Cirrus CI / check?

Looks like a glitch.

nlohmann

Please add tests.

nlohmann · 2026-05-14T13:41:02Z

I think this can be closed in favor of #5169.

RUSLoker · 2026-05-14T17:11:02Z

@nlohmann, I haven't found any tests in #5169. Maybe you should take mine?

nlohmann · 2026-05-14T17:12:28Z

Sounds good, so please update to the latest develop branch.

# Conflicts: # include/nlohmann/detail/output/serializer.hpp # single_include/nlohmann/json.hpp

Signed-off-by: rusloker <klokotkov@ya.ru>

RUSLoker · 2026-05-14T19:07:27Z

@nlohmann, added fix to your solution. Reason described in the code comment.

…type safety Signed-off-by: rusloker <klokotkov@ya.ru>

Signed-off-by: rusloker <klokotkov@ya.ru>

nlohmann · 2026-05-15T12:13:09Z

Please check the DCO requirements.

nlohmann

Looks good to me.

RUSLoker · 2026-05-15T15:08:29Z

Yeeeeah, finally my fix would be merged after 3 years :) Danke!

nlohmann · 2026-05-15T17:25:30Z

Thank you!

RUSLoker requested a review from nlohmann as a code owner January 25, 2023 15:35

github-actions Bot added the S label Jan 25, 2023

nlohmann requested changes Jan 25, 2023

View reviewed changes

C++11 compatibility

cb7f534

Signed-off-by: Kirill Lokotkov <klokotkov@ya.ru>

RUSLoker requested a review from nlohmann January 25, 2023 15:46

gregmarr reviewed Jan 25, 2023

View reviewed changes

Comment thread include/nlohmann/detail/output/serializer.hpp Outdated

Shorter solution

acd35a2

Signed-off-by: Kirill Lokotkov <klokotkov@ya.ru>

Applied amalgamate

bb2722e

Signed-off-by: rusloker <klokotkov@ya.ru>

RUSLoker requested review from gregmarr and nlohmann and removed request for gregmarr and nlohmann January 26, 2023 08:46

gregmarr approved these changes Jan 26, 2023

View reviewed changes

nlohmann added the please rebase Please rebase your branch to origin/develop label Jan 31, 2023

Merge branch 'nlohmann:develop' into patch-1

41592cd

nlohmann removed the please rebase Please rebase your branch to origin/develop label Feb 1, 2023

nlohmann requested changes Feb 1, 2023

View reviewed changes

Merge branch 'nlohmann:develop' into patch-1

34dcf7e

github-actions Bot removed the S label Dec 15, 2023

RUSLoker requested a review from nlohmann May 14, 2026 10:59

github-actions Bot added M tests and removed S labels May 14, 2026

Merge branch 'develop' into patch-1

e4b1f74

# Conflicts: # include/nlohmann/detail/output/serializer.hpp # single_include/nlohmann/json.hpp

gregmarr reviewed May 14, 2026

View reviewed changes

Comment thread tests/src/unit-serialization.cpp Outdated

Fix UB in snprintf_float by using %.*Lg for long double

b803238

Signed-off-by: rusloker <klokotkov@ya.ru>

nlohmann reviewed May 15, 2026

View reviewed changes

Comment thread include/nlohmann/detail/output/serializer.hpp

Comment thread include/nlohmann/detail/output/serializer.hpp Outdated

Comment thread tests/src/unit-serialization.cpp Outdated

Use std::array for values in serialization unit tests to improve …

615c69a

…type safety Signed-off-by: rusloker <klokotkov@ya.ru>

RUSLoker requested a review from nlohmann May 15, 2026 08:31

nlohmann reviewed May 15, 2026

View reviewed changes

Comment thread tests/src/unit-serialization.cpp Outdated

Fix brace initialization for std::array in serialization unit tests

84f6858

Signed-off-by: rusloker <klokotkov@ya.ru>

RUSLoker requested a review from nlohmann May 15, 2026 12:02

Remove comments in snprintf_float regarding %Lg usage

ecafc47

Signed-off-by: rusloker <klokotkov@ya.ru>

RUSLoker force-pushed the patch-1 branch 2 times, most recently from 30dd3ba to ecafc47 Compare May 15, 2026 13:49

nlohmann removed the please rebase Please rebase your branch to origin/develop label May 15, 2026

nlohmann approved these changes May 15, 2026

View reviewed changes

nlohmann added this to the Release 3.12.1 milestone May 15, 2026

RUSLoker requested a review from gregmarr May 15, 2026 15:06

nlohmann merged commit b1bb9fc into nlohmann:develop May 15, 2026
140 of 143 checks passed

nlohmann mentioned this pull request May 16, 2026

Test "dump for basic_json with long double number_float_t" fails when run with Valgrind #5175

Closed

2 tasks

RUSLoker mentioned this pull request May 16, 2026

Fix long double inf test under Valgrind. Fixes #5175 #5176

Merged

5 tasks

Uh oh!

Conversation

RUSLoker commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 25, 2023

🔴 Amalgamation check failed! 🔴

Uh oh!

nlohmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jan 25, 2023

🔴 Amalgamation check failed! 🔴

Uh oh!

github-actions Bot commented Jan 25, 2023

🔴 Amalgamation check failed! 🔴

Uh oh!

coveralls commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregmarr left a comment

Choose a reason for hiding this comment

Uh oh!

t-b commented Jan 26, 2023

Uh oh!

nlohmann commented Jan 26, 2023

Uh oh!

nlohmann commented Jan 31, 2023

Uh oh!

RUSLoker commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RUSLoker commented Feb 1, 2023

Uh oh!

nlohmann commented Feb 1, 2023

Uh oh!

nlohmann left a comment

Choose a reason for hiding this comment

Uh oh!

nlohmann commented May 14, 2026

Uh oh!

RUSLoker commented May 14, 2026

Uh oh!

nlohmann commented May 14, 2026

Uh oh!

Uh oh!

RUSLoker commented May 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nlohmann commented May 15, 2026

Uh oh!

nlohmann left a comment

Choose a reason for hiding this comment

Uh oh!

RUSLoker commented May 15, 2026

Uh oh!

Uh oh!

nlohmann commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RUSLoker commented Jan 25, 2023 •

edited

Loading

coveralls commented Jan 26, 2023 •

edited

Loading

RUSLoker commented Feb 1, 2023 •

edited

Loading