Skip to content

Fix warning and add emscripten CI step#4738

Merged
nlohmann merged 11 commits into
developfrom
issue4662
Apr 13, 2025
Merged

Fix warning and add emscripten CI step#4738
nlohmann merged 11 commits into
developfrom
issue4662

Conversation

@nlohmann

@nlohmann nlohmann commented Apr 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner
  • Fixes a -Wsign-conversion compiler warning that occurred when compiling the library with Emscripten em++.
  • Add a CI step that compiles the library with Emscripten em++. We don't yet enable maximal warning flags here, but will probably do so in the future.

Closes #4662

nlohmann added 2 commits April 12, 2025 12:38
@nlohmann
🚨 fix warning
8b7735e 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 add emscripten
718e751 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@coveralls

coveralls commented Apr 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 99.186%. remained the same
when pulling 2844976 on issue4662
into 93e9573 on develop.

nlohmann added 9 commits April 12, 2025 13:29
@nlohmann
👷 add emscripten
e4a7d2c 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 add emscripten
ca9f685 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 add emscripten
52e6a2e 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 add emscripten
7642b0b 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 add emscripten
889ac9d 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 add emscripten
2605aa1 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 add emscripten
83954b7 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 add emscripten
dc9e893 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
📝 add compiler to list
2844976 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann marked this pull request as ready for review April 13, 2025 14:17
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Apr 13, 2025
@nlohmann nlohmann added this to the Release 3.12.1 milestone Apr 13, 2025
@nlohmann nlohmann mentioned this pull request Apr 13, 2025
Closed
2 tasks
vittorioromeo
vittorioromeo approved these changes Apr 13, 2025
View reviewed changes

@vittorioromeo vittorioromeo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nlohmann nlohmann merged commit 4cca3b9 into develop Apr 13, 2025
@nlohmann nlohmann deleted the issue4662 branch April 13, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vittorioromeo vittorioromeo vittorioromeo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI documentation M review needed It would be great if someone could review the proposed changes.

Projects

None yet

Milestone

Release 3.12.1

Development

Successfully merging this pull request may close these issues.

-Wsign-conversion warning to look into when compiling with emscripten em++

3 participants

@nlohmann @coveralls @vittorioromeo