Skip to content

Add tests for special characters in wide strings#5126

Closed
TheUserWW wants to merge 2 commits into
nlohmann:developfrom
TheUserWW:feature/test-more-characters
Closed

Add tests for special characters in wide strings#5126
TheUserWW wants to merge 2 commits into
nlohmann:developfrom
TheUserWW:feature/test-more-characters

Conversation

@TheUserWW

@TheUserWW TheUserWW commented Mar 31, 2026

Copy link
Copy Markdown

Description

This PR adds a comprehensive test file unit-wstring.cpp for JSON library's wide string support. The file tests three wide string types ( std::wstring , std::u16string , and std::u32string ) JSON parsing capabilities, ensuring the library correctly handles wide character inputs with different encodings.

Validates normal wide string JSON parsing, including multilingual text

Signed-off-by: TheUserWW <wcx1615471430@outlook.com>
Signed-off-by: TheUserWW <wcx1615471430@outlook.com>
@TheUserWW
TheUserWW force-pushed the feature/test-more-characters branch from 5064d29 to 516ab89 Compare March 31, 2026 05:13
@TheUserWW TheUserWW changed the title Add tests for RTL languages and special characters in wide strings Add tests for special characters in wide strings Mar 31, 2026
@nlohmann

nlohmann commented Apr 6, 2026

Copy link
Copy Markdown
Owner

I don't see the benefit of adding some more characters to the existing test - we already test some non-ASCII characters, and this PR is not really adding a "comprehensive" test.

Either we go for a complete UTF coverage or we can keep it as superficial as it is.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

@github-actions github-actions Bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label May 7, 2026
@nlohmann nlohmann closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants