Skip to content

Commit c91dc79

Browse files
author
Namrata Madan
committed
fix: use asymmetric keys to sign remote function signature
1 parent cc583b0 commit c91dc79

7 files changed

Lines changed: 228 additions & 73 deletions

File tree

sagemaker-core/src/sagemaker/core/remote_function/client.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@ def wrapper(*args, **kwargs):
369369
s3_uri=s3_path_join(
370370
job_settings.s3_root_uri, job.job_name, EXCEPTION_FOLDER
371371
),
372-
hmac_key=job.hmac_key,
373372
)
374373
except ServiceError as serr:
375374
chained_e = serr.__cause__
@@ -406,7 +405,6 @@ def wrapper(*args, **kwargs):
406405
return serialization.deserialize_obj_from_s3(
407406
sagemaker_session=job_settings.sagemaker_session,
408407
s3_uri=s3_path_join(job_settings.s3_root_uri, job.job_name, RESULTS_FOLDER),
409-
hmac_key=job.hmac_key,
410408
)
411409

412410
if job.describe()["TrainingJobStatus"] == "Stopped":
@@ -1008,7 +1006,6 @@ def from_describe_response(describe_training_job_response, sagemaker_session):
10081006
job_return = serialization.deserialize_obj_from_s3(
10091007
sagemaker_session=sagemaker_session,
10101008
s3_uri=s3_path_join(job.s3_uri, RESULTS_FOLDER),
1011-
hmac_key=job.hmac_key,
10121009
)
10131010
except DeserializationError as e:
10141011
client_exception = e
@@ -1020,7 +1017,6 @@ def from_describe_response(describe_training_job_response, sagemaker_session):
10201017
job_exception = serialization.deserialize_exception_from_s3(
10211018
sagemaker_session=sagemaker_session,
10221019
s3_uri=s3_path_join(job.s3_uri, EXCEPTION_FOLDER),
1023-
hmac_key=job.hmac_key,
10241020
)
10251021
except ServiceError as serr:
10261022
chained_e = serr.__cause__
@@ -1110,7 +1106,6 @@ def result(self, timeout: float = None) -> Any:
11101106
self._return = serialization.deserialize_obj_from_s3(
11111107
sagemaker_session=self._job.sagemaker_session,
11121108
s3_uri=s3_path_join(self._job.s3_uri, RESULTS_FOLDER),
1113-
hmac_key=self._job.hmac_key,
11141109
)
11151110
self._state = _FINISHED
11161111
return self._return
@@ -1119,7 +1114,6 @@ def result(self, timeout: float = None) -> Any:
11191114
self._exception = serialization.deserialize_exception_from_s3(
11201115
sagemaker_session=self._job.sagemaker_session,
11211116
s3_uri=s3_path_join(self._job.s3_uri, EXCEPTION_FOLDER),
1122-
hmac_key=self._job.hmac_key,
11231117
)
11241118
except ServiceError as serr:
11251119
chained_e = serr.__cause__

sagemaker-core/src/sagemaker/core/remote_function/core/pipeline_variables.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ class _DelayedReturnResolver:
164164
def __init__(
165165
self,
166166
delayed_returns: List[_DelayedReturn],
167-
hmac_key: str,
168167
properties_resolver: _PropertiesResolver,
169168
parameter_resolver: _ParameterResolver,
170169
execution_variable_resolver: _ExecutionVariableResolver,
@@ -175,7 +174,6 @@ def __init__(
175174
176175
Args:
177176
delayed_returns: list of delayed returns to resolve.
178-
hmac_key: key used to encrypt serialized and deserialized function and arguments.
179177
properties_resolver: resolver used to resolve step properties.
180178
parameter_resolver: resolver used to pipeline parameters.
181179
execution_variable_resolver: resolver used to resolve execution variables.
@@ -197,7 +195,6 @@ def deserialization_task(uri):
197195
return uri, deserialize_obj_from_s3(
198196
sagemaker_session=settings["sagemaker_session"],
199197
s3_uri=uri,
200-
hmac_key=hmac_key,
201198
)
202199

203200
with ThreadPoolExecutor() as executor:
@@ -247,7 +244,6 @@ def resolve_pipeline_variables(
247244
context: Context,
248245
func_args: Tuple,
249246
func_kwargs: Dict,
250-
hmac_key: str,
251247
s3_base_uri: str,
252248
**settings,
253249
):
@@ -257,7 +253,6 @@ def resolve_pipeline_variables(
257253
context: context for the execution.
258254
func_args: function args.
259255
func_kwargs: function kwargs.
260-
hmac_key: key used to encrypt serialized and deserialized function and arguments.
261256
s3_base_uri: the s3 base uri of the function step that the serialized artifacts
262257
will be uploaded to. The s3_base_uri = s3_root_uri + pipeline_name.
263258
**settings: settings to pass to the deserialization function.
@@ -280,7 +275,6 @@ def resolve_pipeline_variables(
280275
properties_resolver = _PropertiesResolver(context)
281276
delayed_return_resolver = _DelayedReturnResolver(
282277
delayed_returns=delayed_returns,
283-
hmac_key=hmac_key,
284278
properties_resolver=properties_resolver,
285279
parameter_resolver=parameter_resolver,
286280
execution_variable_resolver=execution_variable_resolver,

0 commit comments

Comments
 (0)