Merge pull request #49 from nmfs-opensci/eeholmes-patch-2

fix quotes in action.yml

Author: eeholmes

.github/actions/create-draft-release/action.yml

@@ -1,28 +1,28 @@
-name: Create draft release
-description: Create a draft GitHub Release using VERSION from Dockerfile (YYYY.MM.DD). Fails if VERSION is missing or malformed.
+name: "Create draft release"
+description: "Create a draft GitHub Release using VERSION from Dockerfile (YYYY.MM.DD). Fails if VERSION is missing or malformed."
 
 inputs:
   tag_prefix:
-    description: Optional prefix for the tag (e.g. v). Default is empty.
+    description: "Optional prefix for the tag (e.g. v). Default is empty."
     required: false
     default: ""
   dockerfile_path:
-    description: Path to Dockerfile to parse version from
+    description: "Path to Dockerfile to parse version from"
     required: false
-    default: Dockerfile
+    default: "Dockerfile"
   target:
-    description: Git ref/sha to tag (default: current commit SHA)
+    description: "Git ref/sha to tag (default: current commit SHA)"
     required: false
     default: ""
   generate_notes:
-    description: Whether to auto-generate release notes (true/false)
+    description: "Whether to auto-generate release notes (true/false)"
     required: false
     default: "true"
 
 runs:
   using: composite
   steps:
-    - name: Extract and validate VERSION
+    - name: "Extract and validate VERSION"
       id: ver
       shell: bash
       run: |
@@ -50,16 +50,19 @@ runs:
 
         tag="${{ inputs.tag_prefix }}${version}"
         echo "Resolved tag: $tag"
+
+        # Export for later steps
         echo "TAG=$tag" >> "$GITHUB_ENV"
+        echo "tag=$tag" >> "$GITHUB_OUTPUT"
 
-    - name: Create draft release (fails if tag already exists)
+    - name: "Create draft release (fails if tag already exists)"
       shell: bash
       env:
         GH_TOKEN: ${{ github.token }}
       run: |
         set -euo pipefail
 
-        tag="${TAG}"
+        tag="${{ steps.ver.outputs.tag }}"
         title="Release ${tag}"
         target="${{ inputs.target }}"
 

.github/actions/run-notebook-test/action.yml

@@ -1,42 +1,42 @@
 name: Run notebook tests in container
-description: Execute one or more Jupyter notebooks via nbconvert inside a Docker image (as jovyan), using a glob pattern. Writes output notebooks next to inputs.
+description: "Execute one or more Jupyter notebooks via nbconvert inside a Docker image (as jovyan), using a glob pattern. Writes output notebooks next to inputs."
 
 inputs:
   image:
-    description: Full image reference including tag (e.g. ghcr.io/org/repo/image:sha)
+    description: "Full image reference including tag (e.g. ghcr.io/org/repo/image:sha)"
     required: true
   tests_dir:
-    description: Host directory containing tests (default: tests)
+    description: "Host directory containing tests (default: tests)"
     required: false
-    default: tests
+    default: "tests"
   pattern:
-    description: Glob pattern (relative to tests_dir) of notebooks to execute (e.g. test-*.ipynb)
+    description: "Glob pattern (relative to tests_dir) of notebooks to execute (e.g. test-*.ipynb)"
     required: false
     default: "test-*.ipynb"
   exclude_pattern:
-    description: Glob pattern (relative to tests_dir) to exclude (e.g. *-output.ipynb)
+    description: "Glob pattern (relative to tests_dir) to exclude (e.g. *-output.ipynb)"
     required: false
     default: "*-output.ipynb"
   output_suffix:
-    description: Suffix inserted before .ipynb for outputs (default: -output)
+    description: "Suffix inserted before .ipynb for outputs (default: -output)"
     required: false
     default: "-output"
   fail_fast:
-    description: Stop on first failing notebook (true/false)
+    description: "Stop on first failing notebook (true/false)"
     required: false
     default: "true"
   earthdata_user:
-    description: NASA Earthdata username (optional)
+    description: "NASA Earthdata username (optional)"
     required: false
     default: ""
   earthdata_pass:
-    description: NASA Earthdata password (optional)
+    description: "NASA Earthdata password (optional)"
     required: false
     default: ""
   netrc_machine:
-    description: Machine entry for .netrc (default: urs.earthdata.nasa.gov)
+    description: "Machine entry for .netrc (default: urs.earthdata.nasa.gov)"
     required: false
-    default: urs.earthdata.nasa.gov
+    default: "urs.earthdata.nasa.gov"
 
 runs:
   using: composite
@@ -75,17 +75,14 @@ runs:
 
         cd "${TESTS_DIR}"
 
-        # Build list based on pattern, excluding outputs (and any exclude pattern)
         notebooks=( $PATTERN )
         if [ ${#notebooks[@]} -eq 0 ]; then
           echo "::error::No notebooks matched ${TESTS_DIR}/${PATTERN}"
           exit 1
         fi
 
-        # Apply exclusion
         filtered=()
         for nb in "${notebooks[@]}"; do
-          # Exclude by glob
           if [[ "$nb" == $EXCLUDE ]]; then
             continue
           fi
@@ -105,16 +102,11 @@ runs:
         for nb in "${filtered[@]}"; do
           base="${nb%.ipynb}"
           out="${base}${SUFFIX}.ipynb"
+
           echo "------------------------------------------------------------"
           echo "Running: ${TESTS_DIR}/${nb}"
           echo "Output:  ${TESTS_DIR}/${out}"
 
-          # Run inside container; mount tests dir at /tests
-          if ! docker run --rm \
-            -v "$PWD/.. /__dummy__" >/dev/null 2>&1; then
-            : # no-op; just to keep shellcheck calm (we don't use shellcheck here)
-          fi
-
           if ! docker run --rm \
             -v "$(pwd -P):/tests" \
             "${IMAGE}" \

.github/actions/validate-packages/action.yml

@@ -1,16 +1,16 @@
-name: Validate packages in container
-description: Extract pinned Python/R package lists from a Docker image and run repo validation scripts, producing reproducibility/build.log.
+name: "Validate packages in container"
+description: "Extract pinned Python/R package lists from a Docker image and run repo validation scripts, producing reproducibility/build.log."
 
 inputs:
   image:
-    description: Full image reference including tag (e.g. ghcr.io/org/repo/image:sha)
+    description: "Full image reference including tag (e.g. ghcr.io/org/repo/image:sha)"
     required: true
   repo_root_mount:
-    description: Host repo mount path inside container (default: /repo)
+    description: "Host repo mount path inside container (default: /repo)"
     required: false
-    default: /repo
+    default: "/repo"
   python_version:
-    description: Python version for running validation scripts on the runner
+    description: "Python version for running validation scripts on the runner"
     required: false
     default: "3.11"
 
@@ -96,3 +96,4 @@ runs:
         else
           echo "⚠️ validation_status=failed" | tee -a "$GITHUB_STEP_SUMMARY"
         fi
+