Another fix for ISSUE #30 and Issue #31 Closes:#31

Author: nmmapper

nmap3/nmap3.py

@@ -126,8 +126,6 @@ def scan_top_ports(self, target, default=10, args=None):
 
         This top port requires root previledges
         """
-        parser  = NmapCommandParser(None)
-
         if(default > self.maxport):
             raise ValueError("Port can not be greater than default 65389")
         self.target = target
@@ -149,7 +147,7 @@ def scan_top_ports(self, target, default=10, args=None):
 
         # Begin parsing the xml response
         xml_root = self.get_xml_et(output)
-        self.top_ports = parser.filter_top_ports(xml_root)
+        self.top_ports = self.parser.filter_top_ports(xml_root)
         return self.top_ports
 
     def nmap_dns_brute_script(self, target, dns_brute="--script dns-brute.nse"):
@@ -162,7 +160,6 @@ def nmap_dns_brute_script(self, target, dns_brute="--script dns-brute.nse"):
         nmap -oX - nmmapper.com --script dns-brute.nse
         """
         self.target = target
-        parser  = NmapCommandParser(None)
 
         dns_brute_args = "{target}  {default}".format(target=target, default=dns_brute)
 
@@ -174,7 +171,7 @@ def nmap_dns_brute_script(self, target, dns_brute="--script dns-brute.nse"):
 
         # Begin parsing the xml response
         xml_root = self.get_xml_et(output)
-        subdomains = parser.filter_subdomains(xml_root)
+        subdomains = self.parser.filter_subdomains(xml_root)
         return subdomains
 
     def nmap_version_detection(self, target, arg="-sV", args=None):
@@ -466,7 +463,6 @@ def nmap_no_portscan(self, target, args=None):
         """
         if(args):
             assert(isinstance(args, str)), "Expected string got {0} instead".format(type(args))
-
         xml_root = self.scan_command(self.no_port_scan, target=target, args=args)
 
         tcp_results = self.parser.parse_noportscan(xml_root)

nmap3/nmapparser.py

@@ -253,9 +253,10 @@ def parse_noportscan(self, xmlroot):
                     address.append(key.attrib)
                 host_record["addresses"]=address
 
-                for hostname in host.find("hostnames"):
-                    for hosts in hostname.findall("hostname"):
-                        hostnames.append(hosts.attrib)
+                if(host.find("hostnames")):
+                    for hostname in host.find("hostnames"):
+                        for hosts in hostname.findall("hostname"):
+                            hostnames.append(hosts.attrib)
 
                 host_record["hostnames"]=hostnames
 

requirements.txt

@@ -1,3 +1 @@
 simplejson
-sphinx
-sphinx_rtd_theme