app: add fetching data from bme280 sensor#8
Conversation
Refs: #4 Signed-off-by: Natalia Pluta <pluta.natalia.m@gmail.com>
bcef88d to
05067e0
Compare
|
This pull request removes the custom example sensor driver and updates the application to use the standard BME280 sensor on the nRF9160 DK board. It also cleans up related configuration and overlay files, and improves logging and error handling in the main application loop. Switch to BME280 sensor and cleanup of custom sensor:
Application logic and logging improvements:
Driver and build system cleanup:
Overall, these changes simplify the codebase by removing a custom sensor implementation and switching to a standard, supported sensor, while also improving maintainability and logging. |
68ff7a6 to
1b1a0f6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the fire detection system to use a BME280 sensor instead of a custom example sensor for environmental monitoring. The change improves the system by integrating a real environmental sensor that can measure temperature, pressure, and humidity.
- Removes custom example sensor driver and infrastructure
- Integrates BME280 sensor with I2C communication
- Updates application to read and log temperature, pressure, and humidity data
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| drivers/sensor/example_sensor/* | Removes custom example sensor driver files |
| drivers/Kconfig | Removes sensor driver configuration |
| drivers/CMakeLists.txt | Removes sensor driver build configuration |
| app/src/main.c | Updates to use BME280 sensor and read environmental data |
| app/prj.conf | Adds I2C and BME280 configuration options |
| app/boards/nrf9160dk_nrf9160.overlay | Configures I2C2 interface and BME280 device |
| app/boards/nrf54l15dk_nrf54l15_cpuapp.overlay | Removes example sensor configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Remove example_sensor node and add BME280 sensor to nrf9160dk_nrf9160.overlay with correct I2C2 pinctrl and address - Enable logging in prj.conf - Update main.c to use BME280 sensor, fetch and log temperature, pressure, and humidity - Remove unused variables and legacy proximity logic Refs: #4 Signed-off-by: Natalia Pluta <pluta.natalia.m@gmail.com>
- Delete out-of-tree example_sensor driver and its Kconfig/CMake files - Remove references to CONFIG_SENSOR and example_sensor from prj.conf, drivers/Kconfig, and drivers/CMakeLists.txt Refs: #4 Signed-off-by: Natalia Pluta <pluta.natalia.m@gmail.com>
1b1a0f6 to
5603b58
Compare
Refs: #4