Skip to content

Commit 6cb9c9a

Browse files
committed
fix(lint): check target.Close() error returns in SNI policy handler
1 parent 78833ec commit 6cb9c9a

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

internal/proxy/server.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1096,7 +1096,7 @@ func (s *Server) handleConnect(ctx context.Context, writer io.Writer, request *s
10961096
}
10971097
return fmt.Errorf("connect to %v failed: %w", request.RawDestAddr, err)
10981098
}
1099-
defer target.Close()
1099+
defer target.Close() //nolint:errcheck
11001100

11011101
if sendErr := socks5.SendReply(writer, statute.RepSuccess, target.LocalAddr()); sendErr != nil {
11021102
return fmt.Errorf("failed to send reply: %w", sendErr)
@@ -1174,12 +1174,12 @@ func (s *Server) sniPolicyCheck(ctx context.Context, request *socks5.Request, ta
11741174
return io.MultiReader(bytes.NewReader(buf), request.Reader)
11751175
case policy.Deny:
11761176
log.Printf("[SNI->DENY] %s:%d (hostname %s matched deny rule)", ipStr, port, sni)
1177-
target.Close()
1177+
_ = target.Close()
11781178
return nil
11791179
case policy.Ask:
11801180
if s.rules.broker == nil {
11811181
log.Printf("[SNI->DENY] %s:%d (hostname %s: ask treated as deny, no broker)", ipStr, port, sni)
1182-
target.Close()
1182+
_ = target.Close()
11831183
return nil
11841184
}
11851185
log.Printf("[SNI->ASK] %s:%d (hostname %s: waiting for approval)", ipStr, port, sni)
@@ -1188,7 +1188,7 @@ func (s *Server) sniPolicyCheck(ctx context.Context, request *socks5.Request, ta
11881188
resp, reqErr := s.rules.broker.Request(sni, port, proto.String(), timeout)
11891189
if reqErr != nil {
11901190
log.Printf("[SNI->DENY] %s:%d (hostname %s: approval timeout: %v)", ipStr, port, sni, reqErr)
1191-
target.Close()
1191+
_ = target.Close()
11921192
return nil
11931193
}
11941194
switch resp {
@@ -1232,17 +1232,17 @@ func (s *Server) sniPolicyCheck(ctx context.Context, request *socks5.Request, ta
12321232
}
12331233
}
12341234
}()
1235-
target.Close()
1235+
_ = target.Close()
12361236
return nil
12371237
default:
12381238
log.Printf("[SNI->DENY] %s:%d (hostname %s: user denied)", ipStr, port, sni)
1239-
target.Close()
1239+
_ = target.Close()
12401240
return nil
12411241
}
12421242
default:
12431243
// Default verdict (typically deny). Use it.
12441244
log.Printf("[SNI->DENY] %s:%d (hostname %s: default deny)", ipStr, port, sni)
1245-
target.Close()
1245+
_ = target.Close()
12461246
return nil
12471247
}
12481248
}

0 commit comments

Comments
 (0)